When saving the block from the "edit block" page (admin/structure/block/manage/gmap_blocks/%%/configure) the block loses all settings added via the "edit gmap block" page (admin/structure/gmap_blocks/blocks/%%/edit).

Lost data includes custom controls and all location relations (the location itself is not lost). The database relation entry is deleted, and apparently the "settings" column is reverted to default.

Major drupal versions are 7.2 and 7.4.

Comments

richthegeek’s picture

richthegeek commented

Fixed this issue, I don't know how to do a diff/patch though.

Old: (gmap_blocks.module)

254:    function gmap_blocks_block_save(&$block) {
255:
256:        if (!is_string($block['settings'])) {

New:

254:    function gmap_blocks_block_save(&$block, $edit = false) {
255:
256:        if($edit) return;
257: 
258:        if (!is_string($block['settings'])) {

The $edit var is only set when submitting from the admin/structure/blocks form (and in this case, $block == 1). Checking for it's existence allows us to skip the module-specific alteration.