Reviewed & tested by the community
Project:
Organic Groups Mandatory Group
Version:
6.x-1.0-beta1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
20 Feb 2007 at 15:43 UTC
Updated:
27 Sep 2010 at 13:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
pwolanin commentedhmmm, yes this would be a relatively simple change. feel free to test and submit a patch.
Comment #2
geodaniel commentedIt's on my long list of things to do, but as you say it's pretty simple, so I should be able to fit it in pretty soon :)
Comment #3
geodaniel commentedAttached is a patch against 4.7 branch that will add this option (default is to email admins still). I've not tried out the 5.x version of this module yet, but I imagine a slightly modified version of the patch would be applicable there too.
Comment #4
geodaniel commentedSorry, there was a typo in that from a last minute change. Latest version attached.
Comment #5
pwolanin commentedI need to test this, still. Also, I'd suggest slightly different language for the settings form item. Something like:
Comment #6
pwolanin commentedHmmm, maybe it should be more like:
Comment #7
geodaniel commentedSure, sounds good to me - it makes it clearer who will receive the emails.
Comment #8
junyor commentedUpdated patch to Drupal-5.
Comment #9
geodaniel commentedThanks for the updated patch. It would be great to get this into the module.
Comment #10
geodaniel commentedComment #11
geodaniel commentedIt would also be good to get this into the D6 release, but the patch will need re-rolling as all the hunks fail.
Comment #12
darren.ferguson commentedHave patched the d6 module for this functionality the patch is attached.
Comment #13
pwolanin commentedplease double-check your patch. Looks like you made whitespace changes (e.g. line endings ) that amek it difficicult to see where the actual changes occur.
Comment #14
pwolanin commentedComment #15
darren.ferguson commentedI do not see any line endings in the patch, the reason for the changes is the if statement there that has moved everything on the patch.
Comment #16
tsi commentedSubscribing, very wanted feature.
Comment #17
trjohnson commentedWe are running a site and encounter a strange side-effect related to this topic. We have Real Name installed, when these emails are generated from the site the username gets translated into random text, e.g. 'zcpECkyaNK' instead of the normal username.
Being able to modify the notification would be wonderful, or baring that, being able to disable these messages would be helpful too.
Comment #18
mrtorrent commentedsubscribing
Comment #19
sreynen commentedThis looks good to me. The whitespace changes are necessary to maintain proper indenting inside the new if block.