Ability to enable or disable '[x] joined [site]...' emails
geodaniel - February 20, 2007 - 15:43
| Project: | Organic Groups Mandatory Group |
| Version: | 6.x-1.0-beta1 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
It would be nice to have the option of disabling these emails in the admin settings for the module.
#1
hmmm, yes this would be a relatively simple change. feel free to test and submit a patch.
#2
It's on my long list of things to do, but as you say it's pretty simple, so I should be able to fit it in pretty soon :)
#3
Attached is a patch against 4.7 branch that will add this option (default is to email admins still). I've not tried out the 5.x version of this module yet, but I imagine a slightly modified version of the patch would be applicable there too.
#4
Sorry, there was a typo in that from a last minute change. Latest version attached.
#5
I need to test this, still. Also, I'd suggest slightly different language for the settings form item. Something like:
<?php$form['og_mandatory_group_mail'] = array(
'#title' => t('Email group managers'),
'#type' => 'checkbox',
'#default_value' => variable_get('og_mandatory_group_mail', 1),
'#description' => t('Send email to a group's managers when a new user joins the site and joins their group or is assigned to it as a mandatory group.),
);
?>
#6
Hmmm, maybe it should be more like:
<?php$form['og_mandatory_group_mail'] = array(
'#title' => t('Email mandatory group managers'),
'#type' => 'checkbox',
'#default_value' => variable_get('og_mandatory_group_mail', 1),
'#description' => t("Should email be sent to the mandatory group's managers when a new user joins the site?"),
);
?>
#7
Sure, sounds good to me - it makes it clearer who will receive the emails.
#8
Updated patch to Drupal-5.
#9
Thanks for the updated patch. It would be great to get this into the module.
#10
#11
It would also be good to get this into the D6 release, but the patch will need re-rolling as all the hunks fail.
#12
Have patched the d6 module for this functionality the patch is attached.
#13
please double-check your patch. Looks like you made whitespace changes (e.g. line endings ) that amek it difficicult to see where the actual changes occur.
#14
#15
I do not see any line endings in the patch, the reason for the changes is the if statement there that has moved everything on the patch.
#16
Subscribing, very wanted feature.
#17
We are running a site and encounter a strange side-effect related to this topic. We have Real Name installed, when these emails are generated from the site the username gets translated into random text, e.g. 'zcpECkyaNK' instead of the normal username.
Being able to modify the notification would be wonderful, or baring that, being able to disable these messages would be helpful too.