Parameters of hook implementations should match hook definitions

Attached.

Okay, 34KB is pretty big, this is split into two patches, one adding $form_id to form_alters, the other with the parameter name tweaks.

Fixed the failure, should work this time.

Noted. Now it's just unifying names and adding $form_id. Nothing to break here!

Cross-post. Will read and follow up on #6.

I fixed the bits about hook_menu_link_alter, but I agree with chx over sun in terms of including arguments like $form_id.

Paraphrasing myself from IRC, "newer developers often look to core implementations AS the documentation, core should set a good example"

I still have to double check the following hooks:

hook_field_formatter_info_alter(&$info) {
hook_field_formatter_prepare_view($entity_type, $entities, $field, $instances, $langcode, &$items, $displays) {
hook_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
hook_field_attach_form($entity_type, $entity, &$form, &$form_state, $langcode) {
hook_field_attach_load($entity_type, $entities, $age, $options) {
hook_field_attach_validate($entity_type, $entity, &$errors) {
hook_field_attach_submit($entity_type, $entity, $form, &$form_state) {
hook_field_attach_presave($entity_type, $entity) {
hook_field_attach_insert($entity_type, $entity) {
hook_field_attach_update($entity_type, $entity) {
hook_field_attach_preprocess_alter(&$variables, $context) {
hook_field_attach_delete($entity_type, $entity) {
hook_field_attach_delete_revision($entity_type, $entity) {
hook_field_attach_purge($entity_type, $entity, $field, $instance) {
hook_field_attach_view_alter(&$output, $context) {
hook_field_attach_prepare_translation_alter(&$entity, $context) {
hook_field_language_alter(&$display_langcode, $context) {
hook_field_available_languages_alter(&$langcodes, $context) {
hook_field_attach_create_bundle($entity_type, $bundle) {
hook_field_attach_rename_bundle($entity_type, $bundle_old, $bundle_new) {
hook_field_attach_delete_bundle($entity_type, $bundle, $instances) {
hook_field_storage_info_alter(&$info) {
hook_field_storage_details($field) {
hook_field_storage_details_alter(&$details, $field) {
hook_field_storage_load($entity_type, $entities, $age, $fields, $options) {
hook_field_storage_write($entity_type, $entity, $op, $fields) {
hook_field_storage_delete($entity_type, $entity, $fields) {
hook_field_storage_delete_revision($entity_type, $entity, $fields) {
hook_field_storage_query($query) {
hook_field_storage_create_field($field) {
hook_field_storage_delete_field($field) {
hook_field_storage_delete_instance($instance) {
hook_field_storage_pre_load($entity_type, $entities, $age, &$skip_fields, $options) {
hook_field_storage_pre_insert($entity_type, $entity, &$skip_fields) {
hook_field_storage_pre_update($entity_type, $entity, &$skip_fields) {
hook_field_info_max_weight($entity_type, $bundle, $context) {
hook_field_display_alter(&$display, $context) {
hook_field_display_ENTITY_TYPE_alter(&$display, $context) {
hook_field_extra_fields_display_alter(&$displays, $context) {
hook_field_widget_properties_ENTITY_TYPE_alter(&$widget, $context) {
hook_field_create_field($field) {
hook_field_create_instance($instance) {
hook_field_update_forbid($field, $prior_field, $has_data) {
hook_field_update_field($field, $prior_field, $has_data) {
hook_field_delete_field($field) {
hook_field_update_instance($instance, $prior_instance) {
hook_field_delete_instance($instance) {
hook_field_read_field($field) {
hook_field_read_instance($instance) {
hook_field_purge_field($field) {
hook_field_purge_instance($instance) {
hook_field_storage_purge_field($field) {
hook_field_storage_purge_field_instance($instance) {
hook_field_storage_purge($entity_type, $entity, $field, $instance) {
hook_field_access($op, $field, $entity_type, $entity, $account) {
hook_field_settings_form($field, $instance, $has_data) {
hook_field_instance_settings_form($field, $instance) {
hook_field_widget_settings_form($field, $instance) {
hook_field_formatter_settings_form($field, $instance, $view_mode, $form, &$form_state) {
hook_field_formatter_settings_summary($field, $instance, $view_mode) {
hook_file_download_access($field, $entity_type, $entity) {
hook_file_download_access_alter(&$grants, $field, $entity_type, $entity) {
hook_filter_info_alter(&$info) {
hook_filter_FILTER_settings($form, &$form_state, $filter, $format, $defaults, $filters) {
hook_filter_FILTER_prepare($text, $filter, $format, $langcode, $cache, $cache_id) {
hook_filter_FILTER_process($text, $filter, $format, $langcode, $cache, $cache_id) {
hook_filter_FILTER_tips($filter, $format, $long) {
hook_filter_format_insert($format) {
hook_filter_format_update($format) {
hook_filter_format_disable($format) {
hook_help($path, $arg) {
hook_image_effect_info_alter(&$effects) {
hook_image_style_save($style) {
hook_image_style_delete($style) {
hook_image_style_flush($style) {
hook_image_styles_alter(&$styles) {
hook_language_presave($language) {
hook_language_insert($language) {
hook_language_update($language) {
hook_language_delete($language) {
hook_menu_insert($menu) {
hook_menu_update($menu) {
hook_menu_delete($menu) {
hook_node_grants($account, $op) {
hook_node_access_records(Drupal\node\Node $node) {
hook_node_access_records_alter(&$grants, Drupal\node\Node $node) {
hook_node_grants_alter(&$grants, $account, $op) {
hook_node_predelete(Drupal\node\Node $node) {
hook_node_delete(Drupal\node\Node $node) {
hook_node_revision_delete(Drupal\node\Node $node) {
hook_node_insert(Drupal\node\Node $node) {
hook_node_load($nodes, $types) {
hook_node_access($node, $op, $account, $langcode) {
hook_node_prepare(Drupal\node\Node $node) {
hook_node_search_result(Drupal\node\Node $node, $langcode) {
hook_node_presave(Drupal\node\Node $node) {
hook_node_update(Drupal\node\Node $node) {
hook_node_update_index(Drupal\node\Node $node, $langcode) {
hook_node_validate(Drupal\node\Node $node, $form, &$form_state) {
hook_node_submit(Drupal\node\Node $node, $form, &$form_state) {
hook_node_view(Drupal\node\Node $node, $view_mode, $langcode) {
hook_node_view_alter(&$build, Drupal\node\Node $node) {
hook_node_type_insert($info) {
hook_node_type_update($info) {
hook_node_type_delete($info) {
hook_file_load($files) {
hook_file_validate(Drupal\Core\File\File $file) {
hook_file_presave(Drupal\Core\File\File $file) {
hook_file_insert(Drupal\Core\File\File $file) {
hook_file_update(Drupal\Core\File\File $file) {
hook_file_copy(Drupal\Core\File\File $file, Drupal\Core\File\File $source) {
hook_file_move(Drupal\Core\File\File $file, Drupal\Core\File\File $source) {
hook_file_predelete(Drupal\Core\File\File $file) {
hook_file_delete(Drupal\Core\File\File $file) {

I don't personally have time to work on this, but it's still worthwhile.