Closed (fixed)
Project:
Follow
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 Jul 2011 at 18:12 UTC
Updated:
10 Dec 2011 at 06:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jmolivas commentedThis is a small update to the Drupal follow module in order to support Google+ network, to see a demo of this in action just take a look at this blog http://jmolivas.com on the block "Follow me on"
Github
https://github.com/jmolivas/follow
Orignal post entry on my blog
http://jmolivas.com/drupal-follow-google-plus
Comment #2
rwinikates commentedAny chance of backporting this to the 6.x branch?
EDIT: I did this locally and will work on packaging it up to contribute back in a bit.
Comment #3
yareckon commentedyo, could you provide this as a patchfile to 7.x-dev so that those of us who want your code don't have to work off of the github version?
Comment #4
yareckon commentedI guess I can do that too :)
Comment #5
yareckon commentedguess folks need the icons for the icons folders too.. There's not a really good way to maintain a patch including binary files is there. Your use to github starts to make sense...
Comment #6
AlexisWilke commentedThere is my own patch for 6.x
The icons are a real problem as usual... 8-(
The first is the small icon, the second is the large one. The name is wrong in comparison to the patch, it should be:
icon-googleplus.png
Thank you.
Alexis Wilke
Comment #7
AlexisWilke commentedOh! And I added the attribute rel="me" as mentioned in this video:
http://www.youtube.com/watch?v=FgFb6Y-UJUI&feature=digest
I'm not too sure, but I guess the rel="me" should not be added if we're creating a link for the site (versus a link for the user.) I guess a test is necessary to know whether that attribute should be added or not. What do you think?
Thank you.
Alexis Wilke
Comment #8
metakel commentedIs it possible to add service on our own?
Sina Weibo (the Mainland China adoption of Twitter) is very popular in the Chinese population. Some clients requests to add this on their sites.
Comment #9
q0rban commentedHi metakel!
First thing to note, you should search the issue queue before posting, and create a separate issue if you can't find what you're looking for. This thread is solely about adding Google +.
That said, please see the follow.api.php file inside the Follow directory for details on how to add custom networks. Also see #640084: Custom networks. Thanks!
Comment #10
sirkitree commentedHrm, looks like Google Plus changed their icon to these:
64:

32:

16:

See here: https://developers.google.com/+/plugins/badge/config
Comment #11
ericduran commentedAnd here you go.
An updated patches, also cleaned up the whitespace, use the new images, and fix the readme.txt
Comment #12
ericduran commentedA better one.
Comment #13
ericduran commentedAnd now here's a proper git format-patch with the binary images in them.
Comment #14
sirkitree commentedWorks! Using it on Lullabot.com ;)
Comment #15
sirkitree commentedAlso, I applied cleanly to the 6.x-1.x branch
Comment #16
q0rban commented@Eric, if this passes Drupal CS, go ahead and commit it.
Comment #17
robloachAfter some testing, I committed to both Drupal 7 and Drupal 6... I scaled the size of the icons to more closely match the sizes of the other icons that are shipped with the module at 24x24 and 36x36. The small icon is also used by default. You can see that deviation in this commit.
Comment #19
Gessuit commentedI know its been awhile on this post since someone commented, and this may not be the best spot to ask this question. But what do I do with the patchfile Yareckon posted? How do I get it working along with the follow module? I'm a novice at Drupal
Comment #20
AlexisWilke commentedGessuit,
You may just want to use his proposed icons if that's what you wanted. (#5)
For that you'd just smack the existing icons with those and off you go! (hit reload / clear your caches to make sure you get the images updated.)
Thank you.
Alexis Wilke