Hi.
Not sure if this is a bug or not but whenever I download something from my server using fileshare, apaches memory usage increases quite a lot. It does happen when the download starts (or rather when I click the link) and it ends when the download is complete.
Also, no save-file-dialog is presented until the file is "loaded into memory" (meaning that memory usage doesn't increase anymore)
If this is expected behavior feel free to close this bug but it doesn't seem to me like this is the way things should work. It would be difficult to serve large files to simultaneous users.

CommentFileSizeAuthor
#1 fileshare.fopen-DRUPAL-5-1.patch738 bytesdboune

Comments

dboune’s picture

dboune commented
StatusFileSize
new fileshare.fopen-DRUPAL-5-1.patch738 bytes

Hi haeger! Could you please test this patch and see if it helps your situation? It is against DRUPAL-5-1. If I've got the wrong thing and the patch won't apply just let me know and I'll gladly produce another against any source you need.

Thanks! ~Damian

haeger’s picture

haeger commented

Hi.
It works like a charm. Now the memory usage stays at sane levels. Thanks a lot.
Is this something that will go into future releases of fileshare or a fix just for me?

dboune’s picture

dboune commented

Hello! I'm glad the fix worked for you, and thank you very much for the testing.

I see no reason why not at this time. It won't hurt anyone to reduce that stress on their webserver. I will ask Jamie to commit it after few larger patches presently in the works have been committed.

~Damian

haeger’s picture

haeger commented
Status: Active » Reviewed & tested by the community

Since there is a patch and it's ready to be commited (as previous poster said) I'll change the status of this bug. It's been open long enough. The maintainer of the module will decide the fate of the patch.

dboune’s picture

dboune commented

Noting that the above patch has been applied to HEAD.

haeger’s picture

haeger commented
Status: Reviewed & tested by the community » Fixed

So, since the patch has been applied to HEAD, the bug is fixed? I'll assume so and change status. If this is wrong I'm sure someone will tell me.

gintass’s picture

gintass commented
Status: Closed (fixed) » Fixed

...

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.