technorati tags on teaser view break site
mariuss - February 21, 2007 - 01:31
| Project: | Technorati |
| Version: | HEAD |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
If you enable the technorati tags to be shown in the teaser view (that includes the Both option) then the HTML will be completely broken.
#1
This may be related to a problem I was having, where the HTML to my site was completely broken. Here's the change I made to fix it (against 4.7-1.x, but the same but is in HEAD):
--- technorati.module.orig 2007-03-06 14:22:21.000000000 -0800+++ technorati.module 2007-03-06 14:18:19.000000000 -0800
@@ -179,7 +179,7 @@
function theme_technorati_tags($tags) {
$path = drupal_get_path('module', 'technorati') . '/technobubble.gif';
$output = '<div class="technorati_tags">';
- $output = ' <img src="' . $path . '">';
+ $output .= ' <img src="' . $path . '">';
$output .= '<strong>' . t('Technorati Tags: ') . '</strong>';
$output .= implode(' ', $tags);
$output .= '</div>';
As you can see, before the fix, the <div class="technorati_tags"> tag is completely missing from the output! Screw up the HTML, indeed! :-)
-TimK
#2
This is fixed in 5.x-1.0, CVS HEAD and in the upcoming 6.x-1.x-dev version
#3
Automatically closed -- issue fixed for two weeks with no activity.