When running Schema compare, I get various bogus warnings that cannot be fixed by modifying the module.install files.

CommentFileSizeAuthor
#3 schema_compare-1211294-3.patch3.2 KBpillarsdotnet
#1 schema_compare-1211294-1.patch3.15 KBpillarsdotnet
#2 schema_compare-1211294-1.patch3.15 KBpillarsdotnet

Comments

pillarsdotnet’s picture

pillarsdotnet commented
StatusFileSize
new schema_compare-1211294-1.patch3.15 KB

Edit: ignore this.

pillarsdotnet’s picture

pillarsdotnet commented
Status: Active » Needs review
StatusFileSize
new schema_compare-1211294-1.patch3.15 KB

Ignore this.

pillarsdotnet’s picture

pillarsdotnet commented
StatusFileSize
new schema_compare-1211294-3.patch3.2 KB

This is the patch I meant to attach.

krimos’s picture

krimos commented

What do you mean by various bogus warnings ?
Is it something like that ?
Notice: Undefined index: warn in schema_compare() (line 614 of /var/www/vhosts/*/httpdocs/sites/all/modules/schema/schema.module).
Warning: Invalid argument supplied for foreach() in schema_compare() (line 615 of /var/www/vhosts/*/httpdocs/sites/all/modules/schema/schema.module).
Notice: Undefined index: extra in schema_compare() (line 623 of /var/www/vhosts/*/httpdocs/sites/all/modules/schema/schema.module).
Notice: Undefined index: extra in schema_compare() (line 633 of /var/www/vhosts/*/httpdocs/sites/all/modules/schema/schema.module).

Thanks !!

pillarsdotnet’s picture

pillarsdotnet commented

Yes, those and others regarding DATETIME, scale, and precision.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

@krimos: Those PHP notices were fixed with #781250: PHP Notice and #1007844: Undefined index: warn in schema_compare() (line 614

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

Patch needs to be re-rolled. PHP notices have been fixed.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Closed (duplicate)

It actually looks like #1237974: Schema module reporting some Date discrepancies seeks to solve this in a more generic way. Let's merge this into that issue.