Closed (fixed)
Project:
Project issue tracking
Version:
6.x-1.x-dev
Component:
Issues
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Jul 2011 at 04:22 UTC
Updated:
30 Aug 2012 at 01:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
webchickOk, this seems to fix it.
I added an upgrade path for the Body field label, since it would be fairly jarring if that suddenly became "Body" instead of "Description".
Comment #2
dwwThe code looks fine. Is this tested and cool?
Comment #3
webchickWell, I tested it, yeah, and it's deployed on the issue-summaries sandbox. But it could probably use a second set of eyes.
Comment #4
dwwWoo hoo, 13 months later, but now fixed. ;) There were a few problems with the patch so I had to re-roll:
hook_update_N()was (obviously) stale. ;)body_labelinhook_node_info()update_sql()returns an array, but it's meant to be used as a subarray from the thing you return fromhook_update_N(), not the return value itself. So instead of this:$ret = update_sql("UPDATE {node_type} SET body_label = ...We need this:
$ret[] = update_sql("UPDATE {node_type} SET body_label = ...Otherwise, this was working as expected, so I committed and pushed to 6.x-1.x. Thankfully, we're no longer doing our own custom node type via hook_node_info() in D7, so this doesn't need to be ported to that branch.
Cheers,
-Derek