There's a problem when someone creates a banner and upload the file as attachment by clicking the "Attach" button. The file was not uploaded and the javascript (ajax) was broken Only the javascript code was printed on the browser.

I think the cause was the "target" name of the banner form. I think it is reserve word used by drupal and has to be renamed into something like "frame_target".

The attached file fixed this problem. I also created a patch to rename the corresponding field used to store the target values.

Thanks,

CommentFileSizeAuthor
#8 banner.module_0.txt66.51 KBrernst
#1 target_fieldname.patch1.01 KBJhef.Vicedo
upload_js_1.patch2.85 KBJhef.Vicedo

Comments

Jhef.Vicedo’s picture

Jhef.Vicedo commented
StatusFileSize
new target_fieldname.patch1.01 KB

patched to rename the field

cvining’s picture

cvining commented

I'm happy to report this fix worked for me! Drupal 5.1 & Banner-Head.

Thx much!

mfratoni’s picture

mfratoni commented

excuse me but i'm a new of drupal, how fix the banner module head version with the patch released for upload bug?

thanks

dries arnolds’s picture

dries arnolds
Primary language Dutch
Location 🇳🇱 Amsterdam
commented

Same question here. Which files do I have to replace/edit to make this patch work? I'm new to patching modules so...

dries arnolds’s picture

dries arnolds
Primary language Dutch
Location 🇳🇱 Amsterdam
commented

Ok, I found out how to patch a module, but it's too complicated for me. Can anyone post a version of the module updated with these two patches? I would be really grateful!

rernst’s picture

rernst commented

did you want the HEAD version patched, or the 2.2 release?

dries arnolds’s picture

dries arnolds
Primary language Dutch
Location 🇳🇱 Amsterdam
commented

I'm using the HEAD version. Thanks in advance! :)

rernst’s picture

rernst commented
StatusFileSize
new banner.module_0.txt66.51 KB

Patched version is attached.

Also note that you'll have to rename the 'target' field in your banner database tables to 'frame_target' manually if you have installed the module already. And rename 'banner.module.txt' to 'banner.module'

Jhef.Vicedo’s picture

Jhef.Vicedo commented

I think the banner module maintainer is kinda busy, so I would suggest to you guys to try the Advertisement module. Though its currently on beta state, I think its pretty stable. And maybe we could test and report some bugs t o make it to stable stage :)

rernst’s picture

rernst commented

I have been using the advertisement module -- I wasn't already using *anything*. Those people that have been using the banner module extensively may not be able to migrate yet, though.

liquidcms’s picture

liquidcms commented

although Advertisement module doesn't support flash ads.. so pretty useless...

and this (banner) module seems to be riddled with bugs... i get intermittent ads when using file caching, and from reading these posts sounds like file caching may be known to be flaky - but switched to db caching and it only worked for a while and now i get no ads at all.

looks like i may have to look at openads integration since i don't think there is a drupal ad manager ready for prime time yet :(.

summit’s picture

summit commented

Hi,

Please port this great module to the advertisement (ad.module): www.drupal.org/project/ad
There is right now a gap in this module about banners. Somebody is allready busy with flash support (http://drupal.org/node/135567), so with these functionality the ad module will be a great module to manage the ads in drupal.

There is a text_ad module and a image_ad module, but the image_ad module doesn't support banners.
Please port the banner.module to the ad.module and fill in this gap!

greetings,
Martijn