Panels Meta

what are the differences to modules like http://drupal.org/project/nodewords_pagetitle ? Have you considered joining forces with others on similar existing projects? Can you explain why this functionality has to live in a new module?

• please document the difference to other modules on the project page, so that users can easily choose what they need.
• README.txt is missing
• info file: remove "version", this is added by drupal.org packaging automatically
• only list files in the info file that contain classes or interfaces
• "description" in the info file is too short.
• module file: @file doc block missing, see http://drupal.org/node/1354#files
• $new is not a good variable name. New what? $new_operation?
• indentation errors, always use 2 spaces. Use coder to check your code style http://drupal.org/project/coder

project page was not updated with the differences to other modules.

I'm heavily using panels for most of pages, so this module would be very exciting.

Meta tag information should be more configurable with contexts.

I'd still recommend you consider writing it as an add-on for the Metatag module as it includes a lot more meta tags and it would reduce *your* maintenance effort. Also Panels integration is in progress for that module already: #1151938: Panels integration - meta discussion

Additional, you should not use the shortened "u" instead of the spelled out word "you".

Sorry for reply #3, but I just wanted to say "well done" on writing the module, you've done a good job with it, it's just that many of us think it'd do better if it were merged with Metatag rather than as a stand-alone module for the reasons listed above. That said, you'd probably be able to get several of us to help with the effort if you'd like.

Agree, it's better to be involved in the metatag module.

However, thanks for the great work, I think you may consider to be a maintainer of metatag if you agree with this.

@Dustin: There's definite overlap, using Page Manager to control meta tags would be an alternative to using the existing admin/config/search/metatags pages, and given the Page Manager functionality would only work if the module was enabled, I think they could sit together quite happily. I've pinged Dave Reid to give his input.

Basically I'm not a heavy user or developer of Panels, so I'm just completely open to "what I need to do" to add support in the Metatag module, which is why #1151938: Panels integration - meta discussion has been sitting with nothing forever. I'd absolutely want Meta tags to work also if Panels is overriding the node/%node page as well, so again, I'm open to what I can do to help bridge the two together.

I think we need to re-focus this ticket to discuss how best to merge the Panels_Meta module. Thanks for being so understanding, Dustin, now lets work out the best approach and make Metatag even better :-)

I'm going to throw my hat into this mix. I just need some direction on how to help. I have some vested interest in getting meta data into panels display. There still is some validity to meta tags in HTML tags and via empirical data I have seen how important it can be.

Marked #1498734: Panels integration - merge Panels Meta as a duplicate.

how can I install it? I am limited to do the upgrade from Drupal 6 to Drupal 7 for the lack of this module.
please ...

welcome back,

Your project page could still be more informative, as installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Your readme is not very useful (seriously), please make sure your README.txt follows the guidelines for in-project documentation.

while (list($key, $value) = each($operations['children'])) {
IMHO
foreach ($operations['children'] as $key => $value) {
Is a thousand times easier to read
Then you also don't have to reset($operations['children'])

Generally, I don't get the sense of these lines:

  while (list($key, $value) = each($operations['children'])) {
    $operation[$key] = $value;
    [...]
  }
  $operations['children'] = $operation;

Your iterating through the array, building a copy of the same array and then putting the copy of the array into the original one - ??

'noindex' => t('noindex'),
'nofollow' => t('nofollow'),
'noarchive' => t('noarchive'),

I don't think it makes sense to translate such machine name like strings. what about 'noindex' => t('No index (noindex)'),? or just don't translate.

t('@identifier: @title', array('@title' => $title, '@identifier' => $context->identifier)),
also this string makes not much sense to be translatable; format_string would be the better choice here

Your still calling the reader U instead of You

Make sure all your comments end with . ? or !

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.
Results: http://ventral.org/pareview/httpgitdrupalorgsandboxdustin1210648git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Have you given any thought to #27 Dustin Bons? - to get this released as a full project?

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Another similar module: http://drupal.org/project/metatag_panels Meta tags: Panels