In the current implementation of this module the label for days: months: years appear under the numbers. In our website design, we would like to have the labels appear inline. So 2 months: 5 days: 3 minutes, instead of:

2 : 5 : 3
months days minutes

CommentFileSizeAuthor
#4 remove-break-tag-1212090-1.patch1.19 KBspiderman
#2 remove-break-tag-1212090.patch1.2 KBwatsomic

Comments

blackice2999’s picture

blackice2999 commented
Category: bug » feature

Hi,

sorry but this is no bug from this module. The BR tag is coded in the javascript library itself. But i see there ist a option for a compact mode which dont use the br tag i will implement this option to the block form. I think its a good idea to submit the br tag thematic as a bug to the javascript maintainer on: http://keith-wood.name/countdown.html

regards
Dennis

watsomic’s picture

watsomic commented
StatusFileSize
new remove-break-tag-1212090.patch1.2 KB

Created a patch that removes the break tag and replaces it with a non-breaking space, so that the date and time are inline.

blackice2999’s picture

blackice2999 commented

hi watsomic,

thanks but i can´t merge it to the module because we dont have the external javascript here... submit the patch to the maintainer this is the right place for that.

regards
Dennis

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented
StatusFileSize
new remove-break-tag-1212090-1.patch1.19 KB

Attaching a new version of watsomic's patch which works directly from a drush make file.

@Blackice2999: Your workaround to add the 'compact' option within the module sounds like a good idea- please keep us updated and we'll happily update to a maintained fix for this issue :)

blackice2999’s picture

blackice2999 commented

i will work on it this weekend

blackice2999’s picture

blackice2999 commented
Status: Active » Postponed (maintainer needs more info)

Hi,

some updates on that ;) - The current DEV Version supports now the compact mode and also supports the "layout" parameter. For this case here the layout parameter is the right way.

Go to Block settings and activate the layout option. Now copy the template file from module directory "jquery-countdown-layout.tpl.php" to your theme. Edit the file like you want (documentation is inside of the file) - Don't forget to clear the cache in drupal.

If you upgrade to the DEV Version you need to run the update.php. Any feedback are welcome on this.

regards
Dennis

Letharion’s picture

Letharion commented
Status: Postponed (maintainer needs more info) » Fixed

Since no-one provided any feedback for a full year, I'm closing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.