When displaying the user login form on any page, Gigya throws a PHP notice for "Undefined index: #prefix in gigya.module on line 967." (Screenshot attached).

This is because Gigya module is attempting to append a value to $form['#prefix'], but $form['#prefix'] does not yet exist.

The solution I'd like to propose here is that instead of using #prefix and #suffix, it would be a more flexible solution to embed the gigya login options directly in the form as a different form element. This would make it so that other modules could adjust the position of the form wherever they like, though I agree that top and bottom are just about all the customizations that Gigya should offer.

There may be some caveat to embedding directly in the form instead of above/below it, some testing required.

CommentFileSizeAuthor
gigya_login_position-d6.patch1.77 KBquicksketch

Comments

Gigya’s picture

Issue summary: View changes
Status: Needs review » Closed (won't fix)

Gigya's 6.x module is deprecated. We no longer support this version and we encourage upgrading to our latest module.