GreenShadow

You have a LICENSE.txt file in your repository that needs to be removed, since the Drupal packaging script automatically adds the LICENSE.txt file. The waiting time for an application review can be 4 -6 weeks. Please consider reducing your waiting time by contributing to the code review process. All it takes is basic module writing skills. Visit http://groups.drupal.org/code-review for details on how to participate.

Hi nitvirus,

Screenshot.png should be renamed to screenshot.png, all lowercase, otherwise it won't be found on unix system which are case sensitive for filenames.
File permissions should also be changed to 644, on unix systems you don't want to have files executable without a reason, the attached patch should fix those issues.

Also make sure you run your code through the coder module http://drupal.org/project/coder you still have some styles issues:

Coder found 1 projects, 6 files, 9 normal warnings, 35 minor warnings, 0 warnings were flagged to be ignored

Regards,
Antonio

The $Id$ lines can be removed altogether, they were used with CVS, but now drupal is using git as a revision control system and those lines are not needed anymore.

* style.css contains "\r" line endings, please use unix style line endings '\n', see http://drupal.org/node/318#indenting
* README.txt has some formatting problems. Also lines should not exceed 80 characters there.

Don't forget to set the status back to "needs review" if you want to get a review.

Get a review bonus and we will come back to your application sooner.

Seems ok, find one minor problem in the css - padding: 0x;, should be padding: 0;. You should also rename 'For_Dropdown_menu' to something like 'nice_menus'. Bit it should be RTBC.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  
  block.tpl.php
  For_Dropdown_menu/page.tpl.php
  maintainance.page.tpl.php
  node.tpl.php
  page.tpl.php
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  For_Dropdown_menu/nice_menus.css:1:/* $Id: nice_menus.css,v 1.28 2008/07/11 16:04:44 add1sun Exp $ */
  For_Dropdown_menu/nice_menus_default.css:1:/* $Id: nice_menus_default.css,v 1.10 2010/10/09 16:58:04 add1sun Exp $ */
  

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Hi,

You need to take care of coding style issues as reported in automated reviews. There are bad line ending issue, usually GIT takes care of it if you have installed it with proper options enabled. Take a look at it.

Automated review/
Review of the 6.x-1.x branch:

* Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting

block.tpl.php
For_Dropdown_menu/page.tpl.php
maintainance.page.tpl.php
node.tpl.php
page.tpl.php
* Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Manual review:
1) You could add a logo to your theme.
2) The different template files (ie: *.tpl.php) could be place in separate folder called "templates" just like images folder. For ex: templates/node/node.tpl.php and templates/blocks/block.tpl.php
3) The css files could be placed in a separate folder like "CSS" or "Styles"

Should have been marked as needs work after #19.

I assign this one to me, there are new commits to the branch after that comment.

Manual review:

No code in master branch

You have to remove the code in the master branch - that is what http://drupal.org/node/1127732 is about

End of line character

You still have some faulty end of line character (expected "\n" but found "\r\n") - check the first line of all the files and replace it unix end of line character

Alternative syntax

You should use alternative syntax in tpl-files - you do that at most places, but you have missed some, please check the files for those

There are some more stuff, but begin with this and I will come back to you application as soon as possible.

Which editor are you using?

You need to set the status to "needs review" if you want to get a review.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project as soon as possible :-)

Manual review:
See again the css file or directory images. Because the files are missing.
e.g.
style.css
background-image: url(images/more.png);
background-image: url(images/block-bg.png);
background-image: url(images/block-custom.png);
....
Delete the entries, or add a file.

print.css
remove

or change to
/* this is the print.css file for printer */

I've downloaded this theme and it needs some work.

1 - First off, something just seems off with the whole theme folder. there are a lot of strange duplicate files: it downloads with a README.txt and README.txt~, same for the style.css and style.css~ and greenshadow.info and greenshadow.info~ all in the root directory.

2 - The site logo $logo links here:

<a href="/" title="Home" rel="home" id="logo">
            <img src="/sites/all/themes/greenshadow/logo.png" alt="Home">
          </a>

but there is no logo.png in the theme folder (or images folder).

3 - The node.tpl.php is not properly linking to a node on the /node view. The class=" in line 7 is never closed with a second " so the whole thing looks like this:

<div id="node-8" class="node

  &lt;h2&gt;&lt;a href=" node="" 8"="" title="Lobortis">Lobortis

  <div class="meta">
      <span class="submitted">Submitted by <a href="/user/1" title="View user profile.">aaron</a> on Wed, 09/05/2012 - 12:08</span>
  
    </div>

  <div class="content">

4 - There is a style.css in the root theme folder and another style.css in the css folder. It looks like the one in the root folder isn't used, so this should be removed.

5 - There are major spacing / indentation issues in page.tpl.php. See line 38, and 58 and many more in the file. See: http://drupal.org/coding-standards#indenting

6 - This isn't a bug per se, but it doesn't make a lot of sense style wise. You can't read any of the block headers in the Header region or Right Sidebar region because it's a dark text color on top of a dark background color. See screenshot.

Your latest branch has a folder called For_Dropdown_menu was this an oversight that it is still in there?

The default logo still doesn't appear for me either still.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

updated the summary added the path to 6.x branch