Using Timeline with Drupal 4.7 and CCK. The initial focus (as set in the timeline settings-- last date/first date), is not working. I have the top band set for years and the bottom band set for decades. I am using this with CCK and the date module. The timeline loads, but it shows an area several decades away from any of the timeline content (whether I set it to load to the last event or the first).

CommentFileSizeAuthor
#7 timeline-focus-2.patch614 byteschirale
#4 timeline-focus-1.patch802 bytesfranskuipers

Comments

Arto’s picture

Arto commented
Title: Initial Focus Not Working » Initial date focus not working as expected
Version: master » 4.7.x-1.x-dev
Assigned: Unassigned » Arto

Thanks for reporting, Chad. The "last date" focus isn't actually implemented yet, so it doesn't work (this should be fixed for version 1.1).

The "first date" should work fine, though - if it doesn't, please report more specifics or better yet, the minimal setup for reproducing the problem.

miro.log’s picture

miro.log commented
Version: 4.7.x-1.x-dev » 5.x-1.x-dev

Got the same problem, in 5.1: timeline is always loading the current date only, never the nodes' ones.
All the rest is working perfect... anyway, does anybody knows if there's a way to override the problem - i read in the views section that it is possible to pass arguments like YYYY/MM/DD to the timeline... but how to pass them? peace

robomalo’s picture

robomalo commented

Confirming this bug. I also have this problem in the 5 dev release.

franskuipers’s picture

franskuipers commented
Status: Needs review » Active
StatusFileSize
new timeline-focus-1.patch802 bytes

And here is the solution.

It is a patch against the DRUPAL-5 branch, please let me know if you would like it against the HEAD branch.

Enjoy

franskuipers’s picture

franskuipers commented
Status: Active » Needs review

Changed status

bomarmonk’s picture

bomarmonk commented
Status: Active » Needs work

I just tried this patch with the 5.x dev version of timeline and I get the message that "1 out of 1 hunk failed." This fails against the head version as well (I'm using Cygwin and the "patch" command which normally works). Both versions I downloaded as fresh copies from the timeline project.

chirale’s picture

chirale commented
Status: Needs work » Needs review
StatusFileSize
new timeline-focus-2.patch614 bytes

I rewrite franskuipers changes. Try this patch using:

patch -p0 < timeline-focus-2.patch

on timeline directory (I successfully tested it).

franskuipers’s picture

franskuipers commented

@bomarmonk: because you said the patch was rejected, I installed cygwin, checked out a fresh DRUPAL-5 branch and tried my patch: it worked!!!
@chirale: then I tried your patch and I got a reject!!!

I am very sorry but my patchfile is the right one. Chirales patch is wrong, is has WINDOWS style eol and not UNIX style EOL.

Please see: Line endings and directory separators on the handbook page: http://drupal.org/patch/create

@bomarmonk: If you install cygwin again, please don't choose the option in the setup screens: DOS / text but select Unix / binary (RECOMMENDED)

jmiccolis’s picture

jmiccolis commented
Status: Needs review » Fixed

@franskuipers - I've commited your patch. Thanks.

Please note that this patch fixes the reported issue, however as Arto describes in #2 certain focus settings aren't actually implemented.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.