I don't think it makes sense to have the Manage Fields and Manage Display tabs for SPARQL registry. I don't think that we'll have site admins wanting to add additional info to the registry object and it will probably confuse a number of users.

I suggest we change fieldable to FALSE.

CommentFileSizeAuthor
#2 1213192-02-remove-fieldability.patch4.25 KBlinclark

Comments

Anonymous’s picture

Anonymous (not verified) commented
Title: SPARQL Registry should not be fieldable » SPARQL Registry field integration unnecessary

Also, I may be wrong about this, but the field integration doesn't seem to actually be doing anything, so I suggest removing it completely.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new 1213192-02-remove-fieldability.patch4.25 KB

This patch removes all of the code that is related to adding custom fields on the entity.

It also removes the hook_field_extra_fields implementation. The only reason to have that is to move around the fields, so this isn't necessary anymore.

Anonymous’s picture

Anonymous (not verified) commented

Adding tag for bi-weekly code sprint.

stuartraetaylor’s picture

stuartraetaylor commented
Status: Needs review » Needs work

I've applied the patch, but still have the Manage Fields and Manage Display tabs in the SPARQL Endpoints Registry. The patch appears to have applied correctly, I now have 'fieldable' => FALSE in sparql_registry_entity_info().

Anonymous’s picture

Anonymous (not verified) commented

Hmm, did you try clearing your cache? That might do it, let me know if it does.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

Actually, no, you have to do a full reinstall of the module... sorry that I didn't note that before.

stuartraetaylor’s picture

stuartraetaylor commented
Status: Needs review » Reviewed & tested by the community

That's what I forgot to do. Cleared the cache (twice?) and the SPARQL registry is no longer fieldable.

Anonymous’s picture

Anonymous (not verified) commented

Ahhh... yeah, I tried just clearing it once and it didn't do anything either. I should remember: when in doubt, clear twice ;)

Thanks for the review again!

Fixed with commit http://drupalcode.org/project/sparql.git/commit/649d631

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Fixed

i meant fiiiixxxxed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sun.core’s picture

sun.core commented