Download & Extend
Issues

Optimize count(has) quiery

Posted by andypost on July 8, 2011 at 6:51pm
Project:Drupal core
Version:8.x-dev
Component:aggregator.module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Administration, Performance

Issue Summary

This place only ensures that category exists so should be converted to optimized "exist" query type

AttachmentSizeStatusTest resultOperations
aggregator_count.patch591 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 33,543 pass(es).View details
Login or register to post comments

Comments

#1

Posted by andypost on July 13, 2011 at 9:01am

Any reviews? Patch so simple...

aggregator_count.patch queued for re-testing.

#2

Posted by twistor on August 26, 2011 at 5:53am
Status:needs review» reviewed & tested by the community

It works. I actually think it makes the intention of the code clearer as well. It checks that a category exists rather than how many exist.

#3

Posted by oriol_e9g on August 26, 2011 at 7:06am
Title:Optimize count(has) quiery» Optimize count(has) query

#4

Posted by Lars Toomre on August 26, 2011 at 7:13am
Title:Optimize count(has) query» Optimize count(has) quiery

This makes sense and helps avoid COUNT(*) query in MySQL Innodb tables (good!!).

#5

Posted by Dries on August 26, 2011 at 9:02am
Status:reviewed & tested by the community» fixed

Committed to 7.x and 8.x. Thanks.

#6

Posted by System Message on September 9, 2011 at 9:11am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#7

Posted by sun.core on September 22, 2011 at 12:33pm
Issue tags:+Administration, +Performance
nobody click here