Jump to:
| Project: | Node Relationships |
| Version: | 6.x-1.x-dev |
| Component: | Documentation |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
Issue Summary
This code is very bloated. I'm trying to customize some stuff for a client, and this module is proving unwieldy; it has tons and tons and tons of code, and not very much documentation. Furthermore, it has many features piled into one module -- it'd be better split out into several modules:
- Enhancements for node reference fields: "Search and reference view" (single
and multiple selection based on dynamically configured views), "Create and
reference" and "Translate and reference" (when the Drupal core translation
module is enabled, with additional support for Internationalization module).
These features use the Modal Frame API to provide popup dialogs from buttons
attached to node reference fields configured to use the autocomplete widget.
- Automatic back references using dynamically configured views that are able
to extract the relations from existing database information. This views can
be rendered using a myriad of methods in the node view.
- The Node Relationships module provides default views for each feature that
can be modified and/or cloned (recommended) should you need to add more
fields, filters or change any other option to suit your needs.
- Basic entity relations diagram (ERD) that can be used to view the relations
of each individual content type. The provided diagram can be used to walk the
relationships of all types in the system.The first, second, and fourth features should each be in their own modules, thus making it easier to navigate within the project and figure out where the code I'm trying to modify is; also, it would allow disabling some of the features while retaining other features. On the site I'm working on, I only need a selected portion of the functionality under the first bullet point. It would be great to turn off the other parts and keep just this one.
On this same point, the functionality "Automatic back references" seems to be the same as another module by the same maintainer, http://drupal.org/project/reverse_node_reference. It would be great if there could be one canonical source for the functionality.
Comments
#1
Well, complex is a relative concept. Another issue is that I had not more time to document, but maybe others could help here...
#2
I agree there, but this isn't really what the issue is about -- it's about the fact that there are many not-really-related features piled into one large module. If they were split up into other modules, it would be a lot more manageable. For example, I could turn on only the part I needed. Additionally, the backreferences seems like a duplicate of corresponding_node_references, but I could be wrong there.
#3
Re: "Additionally, the backreferences seems like a duplicate of corresponding_node_references, but I could be wrong there."
Excuse me, but if you're not really sure, why do you say that? What's the purpose of your issue? It really looks that you're trolling against this module.
I do not have much time to maintain the module, and less time to re-think/re-implement the module. This may or may not be ok, but it is as it is. I coded this module for request, and because there was nothing like this before. That means this module is "feature frozen". Then I shared it. It may or may not like others. Good. What can I say? Live your own way and let others live their own.
One thing is for sure, is that one will find the door closed when simply coming to criticize. If one wants to help, then the door is open. This being said, I would suggest thinking about D7, and that means the picture has changed significantly, enough to maybe think on a different module.
#4
I'm trying to give constructive criticism: I suggested a way for this module to improve. I didn't say you need to take this suggestion. We both have limited time. That said, duplication between modules is looked down upon, and I wanted to point out to you that this module duplicates the functionality of another module. While I was at it, I figured that other components of the module could be separated as well. If you don't feel this is correct, nobody is making you do this, and even if I was to supply a patch, nobody would make you commit it.
#6
Re: "duplication between modules is looked down upon, and I wanted to point out to you that this module duplicates the functionality of another module."
Could you please be more explicit? Which feature and step by step on how it can be done with another module?