Closed (won't fix)
Project:
e-Commerce
Version:
5.x-3.x-dev
Component:
address
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
21 Feb 2007 at 19:39 UTC
Updated:
13 Oct 2008 at 11:26 UTC
Jump to comment: Most recent file
Comments
Comment #1
Bevan commentedrelated to : http://drupal.org/node/121359
Comment #2
elio commentedFlexicharge don't work with addressed submited with ec_anon, I need to fix it, do you know something about anon and address integration problems?
I look forward...
Comment #3
simeelio, please open a new ticket against flexicharge rather than spamming every shipping/address ticket you can find.
Comment #4
elio commentedSorry, I opened.... yes you were righ I was in panic.
Comment #5
notauseranymore commentedI wanted the same feature.
A 'shipping address is same as billing address checkbox' so users don't have to fill in their address twice.
Here is a simple 5.x patch to address.module to provide this.
Christopher Hamersley
www.hemisphere3.com
Comment #6
Bevan commentedCool!!! My client's site is launched and he's happy with it (didn't comment on this). But I'll check your patch out and integrate when we next do a revision... tks
Comment #7
simeBump. Patch here for "shipping same as billing address checkbox"
Comment #8
Striatum commentedcan you integrate this for 3.4 or update the patch to work with 3.3?
Comment #9
Bevan commentedThis issue is set to version 5.x-3.x-dev -- so it should work with the most recent version of EC in the 3.x series.
Can anyone who has used this patch please report successes and/or failures...
Comment #10
Striatum commentedI tried with 3.3 and both hunks fail
Comment #11
gordon commentedThis is a new feature that will not be included into v3. Normally I would commit something like this into v4, but this entire area has been re-written and this will not apply.
Please feel free to port this to v4 and resubmit.
Comment #12
smoothstr@drupal.org commentedThanks for your patch Christopher. I'll be applying it to a customer's new 5.2 site because I've just discovered that this still hasn't been sorted, which is quite surprising seeing as this is one of those basic usability things that it seems to me that anyone who is running ecommerce and selling anonymously would want.
[mild rant]It's a bit of an annoyance that this bit of code has been written several times and hasn't yet been accepted. I think I had the same response to my version of this which was against version ec 2. I did make the mistake of also fixing a bunch of other address problems at the same time, which made the patch complex, and not having the time to port the patch to head. Still it made our customers happy, even if nobody else who runs Drupal ecommerce benefited from the work. [/mild rant]
Gordon, it's a pity that Christopher submitted this in April, but it's taken till August till he got a reply. I expect that there are good ways that people could help. Maybe if you put a link in your signature to ways to help/stuff that needs doing/procedures node? Just to clarify because writing like this doesn't convey tone well: I am not criticizing or being snippy - I know you have done a vast amount of work towards ecommerce - I'm trying to figure out ways to help within limited time because it looks like there's a process problem.
jeff
[Update on preview: Yes, I was being snippy with the mild rant even though it was my fault: if I wanted it in ec, I should have patched against head. But I don't run head, and neither do our customers and time is always a problem.]
Comment #13
biohabit commentedI also really need this feature, has anyone got it working with 3.3?
Comment #14
Phillip Mc commentedthe patch posted by kaksisa works with the address.module for version 5.x-3.4
just thought I'd mention it.
Phil
Comment #15
reg commentedI was looking at the patch and I can't see how it it correct. These lines say:
if ($txn->address['shipping']['shippingSame']) {
$txn->address['shipping'] = address_get_address($txn->billing_address);
} else {
$txn->address['shipping'] = address_get_address($txn->billing_address);
}
if one thing then do something but if not do the same something ???
Comment #16
djflux commentedFYI, I was getting the following error for logged in users that already had billing and shipping address in their address book and went back during the checkout process to change an address:
To duplicate:
. Login to a Drupal site using eCommerce 5.x-3.x using the address book
. Create addresses in the address book
. Add an item to the cart and go through the check process to the review screen
. Click on the "change" option for one of the addresses
. Click the continue button
You will receive a blank screen in your browser and the above stdClass error.
I just reverted to the standard address behavior for logged in users ($txn->uid > 0 ).
I've attached a patch that includes everything the above patch has without the logged in user part.
Comment #17
miahawk commentedI tested the patch in post #16 in eC 3.5 and it works.
Comment #18
enxox commentedseem to work for me in 3.5 too