| Project: | Notify |
| Version: | 6.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
Hello,
I am testing drupal 5.1 with different modules including notify. Evrething works fine but I failed with notify module.
1. Extract the notify module directory, including all its subdirectories, into
your sites/all/modules directory - OK !
2. Enable the notify module on the Administer >> Site building >> Modules page - OK !
3. Modify permissions on the Administer >> Users >> Access control page
notify module.
checked access notify & administer notify
OK !
4. Go to Administer >> Content >> Notification settings
Send notifications every:15 minutes
How often should new content notifications be sent? 20
OK !
Enabled cron to run every 1 minute - OK !
(I checked log - cron is OK)
5. To enable your notification preferences, click on the "My notification
settings" on the "My account" page.
Notify status: Enabled
Do you wish to receive periodic e-mails when new content is posted?
Detailed settings
Notify new content: Enabled
Include new content in the notification mail.
Content: Title + Body
Select the amount of each post that you would like to see in your notification e-mails.
Notify new comments: Enabled
OK!
6. Additional options can be set at Administer >> User management >> Users by
clicking the "Notification settings" tab.
checked Flush e-mail queue and saved, output: - "Notify settings saved.
No notification e-mails needed to be sent".
I tested and posted different content (stories, comments) as anonymous and registrated user, but failed to be notified to my admin e-mail.
Am I missed something?
Thanks,
Roman
Comments
#1
Is there anyone who uses drupal 5.1 with notify module?
Thanks,
Roman
#2
Yes, I for one do use Notify with Drupal 5.1 on many sites already. But with the description you provided I fail to see why it doesn't work for you. Can you look at your logs and see if there are entries like:
"cron 2007-02-22 15:36 Executed notify_cron, took 0 sec."?
#3
Here is my latest log:
cron 2007-02-22 15:35 Cron run completed (via poormanscron). admin
cron 2007-02-22 15:35 Executed notify_cron via poormanscron, took 0 sec. admin
cron 2007-02-22 15:35 Executed watchdog_cron via poormanscron, took 0 sec. admin
cron 2007-02-22 15:35 Executed statistics_cron via poormanscron, took 0 sec. admin
cron 2007-02-22 15:35 Executed node_cron via poormanscron, took 0 sec. admin
cron 2007-02-22 15:35 Executed filter_cron via poormanscron, took 0 sec. admin
It seems notify module is ok, but I have no any e-mail notifications about new content.
Regards,
Roman
#4
I have the same problem with Notify on Drupal 5.1 - no errors were reported but also no emails have been sent.
#5
Can you both list the version on the top of your notify.module?
#6
Hello RobRoy,
Here is top string of my notify module:
// $Id: notify.module,v 2.67 2007/01/05 07:53:43 robroy Exp $
I can provide you ftp & admin account access to my testing site if you are interested.
Thanks,
Roman
#7
I just tested on the latest Drupal 5.x-dev and notify works fine. Is there anything in your admin logs or php logs?
#8
Hello RobRoy,
No any errors in the logs & status report, but I have no e-mail notification about new content. It looks that evrething is OK, but I have no e-mail notifications by notify module.
I use poormanscron module to run cron, but I tried to use notify module manually:
1. posted new content and comments as a guest and as a registrated user
2. loged as an admin (I have 2 admin accounts and all them have enabled notification options in "My notification settings" )
3. run cron manually
4. Users management > users > notifications > checked Flush e-mail queue and save settings
5. Clicked "save settings"
6. Output: "Notify settings saved. No notification e-mails needed to be sent ".
Any ideas?
Thanks,
Roman
#9
Hi,
This is the line at top of notify.module:
// $Id: notify.module,v 2.67 2007/01/05 07:53:43 robroy Exp $
BUT !!! when I ran cron 5 mins ago (Feb 23 8pm) notifications were sent (nothing was changed in configuration on the site). Issue must be related to the time functions/settings. Content was created Feb 22 ~9pm and crons that ran immediately after that did not send anything.
Hope this helps. Thanks for the very useful module!
#10
Hello vlajko,
Have you tested notify module and started cron after 15 minutes (1 hour) after new content had been created?
I failed to test notify: I started cron 1, 12 and 24 hours after new content had been created - no any e-mail notifications!
Notification settings allow to choose how often should new content notifications be sent, but it does not work for me!
Thanks,
Roman
#11
I re-installed my testing drupal site with all modules I use including notify. I discovered that notify module works only if new contents (comments, stories) are published by default. Notify does not work for new posted Stories if I have not checked default option "Published" in Content types (Home » Administer » Content management » Content types). Notify does not work for new posted comments if I have not checked "post comments without approval" in Access Control (Home » Administer » User management
Access control).
It would be reasonable to fix notify module in order to inform administrators about new posted pending content (not published by default) .
Thanks,
Roman
#12
'm tempted to mark this 'by design'. Notify will only send out content that is marked published and was created since the last notify_cron run. If cron runs, then the content is marked published afterwards, it won't notice it. For this use case we'd have to keep a record of which nodes have been notified and that is a lot of additional functionality for an edge case IMO.
Of course I'm to accept a patch or more info.
#13
Perhaps a different option could allow notify to send out content that is marked "In moderation queue" (via the Modr8 module) and has been created since the last cron run. Another good option would be to integrate with the Revision Moderation module, and send content whose revision has been created since the last cron run but the new revision is not yet published. This would be very convenient for sites that allow multiple contributors of content but require content to be approved before being published.
#14
@emdalton: because notify does 'all or nothing', you can't adjust which nodes/terms to be send to whom, this won't work. You shouldn't send notification of content that isn't published yet, period. It is 'not published' by reason, because nobody should read it yet.
In our own cms we created, we set an extra notify flag to every content item. As Robroy stated, that's a bit more to it. But it would be a nice feature!
By the way, Drupal 5.1 and notify 5.x-1.x-dev works fine here.
#15
I recommend the following:
1) Create a new role permission to receiving notifications for new, unpublished nodes. Call it "unpublished notifications"
2) Give users with this permission the option to receive new, unpublished node notifications if they so choose.
I may get around to coding this myself but for now, since only administrators receive notifications, I commented out part of the WHERE clause in line 336 like so:
$nresult = db_query(db_rewrite_sql('SELECT n.nid FROM {node} n WHERE /*(n.status = 1 OR n.moderate = 1) AND*/ n.created > %d AND n.created <= %d ORDER BY n.created'), $period, time());This works good enough for now.
#16
#17
I had problems configuring the Notification module on Drupal5.x with similar symptoms.
I see in your logs that you are using Poormanscron.
I experienced similar issues and ultimately decided my problems were with Poormanscron not the Notification module.
Your success with the Notification module running cron manually by hitting /cron.php confirms that the problem is with Poormanscron and not the Notify module.
I dropped use of Poormanscron and now use pure cron and it works perfectly since. Drupal should work faster with fewer modules anyway.
Hope this helps.
#18
I've heard of other issues with poormanscron.
Consider using a webcron service instead:
http://www.webcron.org/
http://supertask.net/
#19
Very helpful in understanding the purpose and function of the Notify module, and how to get it to run.
I now understand that the Module is made to notify of published items--but the function which it seems many of us are looking for is the ability to be notified when an item has been posted for approval. We need to have the appropriate maintainer able to go in quickly and approve, or not, the material--yet the maintainer simply cannot be checking all the time.
I've noticed this kind of notify function in other CMS--dotNetNuke (pardon the mention) has it, and I think Joomla does as well. Actually, For my purposes it's actually a critical function--is such a module available?
SteveCarter
#20
I think notify.module should be this module, a module for the admins to alert them of new content to be moderated.
I don't think notify should be used by the users. We have subscriptions.module for that.
So, this is definitely a feature I want to add to this module. I am waiting for a proper patch. See my priorities: http://drupal.org/node/159427
#21
I know of no module or combination of modules that will notify a specific user (e.g. an editor) on the revision of content, but to notify on submission of new content, we're going to use Workflow and Actions. Unfortunately, revisions can't trigger actions (yet).
#22
In the case of notifying site Admins of new, unpublished comments, the following change will work. It's somewhat inelegant, but it allows anyone with 'administer comments' to get notifications on all new comments, regardless of whether or not they've actually been published. In this way, you can use this module to tell your site admins that there are new comments waiting to be reviewed.
if ( user_access('administer comments', $user) ) { // get all comments, regardless of status$cresult = db_query(db_rewrite_sql('SELECT c.nid, c.cid, c.subject, c.name FROM {comments} c WHERE c.timestamp > %d AND c.timestamp <= %d ORDER BY c.nid, c.timestamp', 'c'), $period, time());
}
else {
// Fetch new published comments
$cresult = db_query(db_rewrite_sql('SELECT c.nid, c.cid, c.subject, c.name FROM {comments} c WHERE c.status = %d AND c.timestamp > %d AND c.timestamp <= %d ORDER BY c.nid, c.timestamp', 'c'), COMMENT_PUBLISHED, $period, time());
}
The above replaces the existing comments query around line 346:
// Fetch new comments.$cresult = db_query(db_rewrite_sql('SELECT c.nid, c.cid, c.subject, c.name FROM {comments} c WHERE c.status = %d AND c.timestamp > %d AND c.timestamp <= %d ORDER BY c.nid, c.timestamp', 'c'), COMMENT_PUBLISHED, $period, time());
#23
Fix to the above:
if ( user_access('administer comments', $user) ) { // get all comments, regardless of statusShould actually be:
if ( user_access('administer comments') ) { // get all comments, regardless of statusUpdated Diff attached. This one has been tested with non user/1 users... (hooray for QA people)
#24
I believe this issue is resolved in current versions of the module. If the 5.x version still has issues which are fixed by the patch in #23, someone please mark RTBC.
#25
Automatically closed -- issue fixed for 2 weeks with no activity.
#26
Hey there,
this issue is still unsolved in the latest 6.x branch - if the content is not published or not in moderate state, a notification is not being sent about it. (IIRC the moderate=1 option is pretty much useless unless the modr8 module is used together with notify).
Cheers,
Martin