Standings problem

Thanks for the report!

My first guess is that the combination of modules you've enabled has flushed out a built-in dependency I didn't consider ... Can you confirm whether or not you've enabled the 'ult_registration' module?

Patch attached ... fix commited to 6.x-1.x-dev.

Sounds good ... let me know if it works for you!

Patch definitely doesn't work. The $table variable is not defined.

That's odd ... The $table variable is defined in lines 346 through 351 of the ult_standings module:

function ult_standings_getactiveleagues($type = 'league') {
  if ($type == 'league') {
    $table = 'content_type_ult_league';
  }
  elseif ($type == 'division') {
    $table = 'content_type_ult_division';
  }
  else {
    watchdog('ult_standings', t('Illegal "type" value passed into ult_standings_getactiveleagues'));
    return array();
  }
  $lids = array();
  if (module_exists('ult_registration')) {
    $sql = 'Select a.nid from {' . $table . '} a, {content_field_ult_leaguestatus} b where a.nid = b.nid and b.field_ult_leaguestatus_value = "Active" ';
  }
  else {
    // If ult_registrations not installed, there is no 'status' table.
    // Assume all leagues are 'active'
    $sql = 'Select nid from {' . $table . '}';
  }
  $result = db_query($sql);
  while ($data = db_fetch_object($result)) {
    $lids[] = $data->nid;
  }
  if (count($lids) > 0) {
    return $lids;
  }
  else {
    return FALSE;
  }
}

This function is only called from two places ... lines 153 and 157 of ult_standings.module. One instance calls it with no arguments (which causes the default $type="league" argument to be assumed), and the other calls it with the argument "division". Therefore, one of the first two 'if' conditions should always be invoked, and thus the $table variable should always be defined.

I wonder if perhaps the patch didn't apply properly (or was applied against an earlier version of the code) ... Can you verify that your resulting function looks like the above, after the patch has been applied?

I think you're looking at the wrong function. The patch makes changes to ult_standings_getcurrentsession() however you're referring to ult_standings_getactiveleagues()

Yup ... you're right ... the patch is applying against the wrong function. Not sure how that happened ... I'll re-roll and get something back here in about 20 minutes.

Updated patch ... let me know if it works, and sorry for the trouble!

Works well, thanks

Reverted bad patch and applied new one ... fix commited to 6.x-1.x.

Thanks for the heads up!

This fix was incomplete ... also see the patch posted at http://drupal.org/node/1529370#comment-5884418