Block for quick backswitches use user_load in cycle just tot get uid and name.
It's bad practice and have bad perfomance impact.

I propose use single SQL query to fetch this data at once.

CommentFileSizeAuthor
#1 user-load-in-cycle-1214410-1.patch1.88 KBIRuslan

Comments

IRuslan’s picture

IRuslan commented
StatusFileSize
new user-load-in-cycle-1214410-1.patch1.88 KB
nigelcunningham’s picture

nigelcunningham commented

While working on another module, I noticed that Masquerade does this a lot. Is there a reason? If not, I'll happily provide a patch to do this module-wide (or as much as possible).

andypost’s picture

andypost
he/him
Primary language Russian
commented

This is a really annoying but required to allow modules a-la realname to work - override a username

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

Suppose we needs more reviews

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

I am closing this bug report, as Drupal 6 is no longer supported. Please re-open it if the issue is still relevant for the Drupal 7 or 8 version of the module.