When libraries module is enabled drush_git_deploy_download() downloads the Glip library to sites/all/libraries/glip/glip when it should be in sites/all/libraries/glip

CommentFileSizeAuthor
#1 1214494-1-glip_clone_location.patch552 bytesfenstrat

Comments

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Title: Incorrect Glip download location with libraries in drush_git_deploy_download() » Incorrect Glip clone location with libraries in drush_git_deploy_download()
Status: Active » Needs review
StatusFileSize
new 1214494-1-glip_clone_location.patch552 bytes

Correcting this is simply a matter of removing drush_mkdir($path) because the call to git clone already creates the glip dir.

Freso’s picture

Freso commented

Looks good to me. At first I was thinking that the drush_mkdir() might as well be kept, but then I realised that the directory is being created, and then "/glip" is added onto the path - which is then where the Git clone goes to, which is when the directory is being created.

If anybody can confirm that this fixes it, it should be good to go.

bforchhammer’s picture

bforchhammer commented
Status: Needs review » Reviewed & tested by the community

Tested & Confirmed. :-)

Freso’s picture

Freso commented
Title: Incorrect Glip clone location with libraries in drush_git_deploy_download() » Incorrect Glip clone location with Libraries in drush_git_deploy_download()
Status: Reviewed & tested by the community » Fixed

Thank you both. It has been committed and pushed.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

Thanks Freso.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.