I've added two ad slot (units) on several panel pages (approx. 50 pages).
Changing the ad unit title inside DFP breaks the connection to the GAM module.
Changing the ad slot title inside the GAM module breaks the connection to the blocks or panel panes.
I can fix this by generating a new MD5 hash for the block ID and apply it manual inside the db.

What about adding a numeric ID to all GAM slots and connect this ID to the Ad unit titles instead of generating
a md5 hash?

e.g. instead of google_admanager-f0ded22453cff757fc0822f102792f29 just google_admanager-1234

Comments

jcisio’s picture

jcisio commented

It's because of #624284: Changing ad slot order in settings screws up block settings.

GAM use block delta to save ad unit name and in Drupal, block delta can not exceed 32 characters. So we decided to use md5 hash.

There are two methods to solve this:
- GAM can of course be more intelligent to use md5 only when necessary (like Views). But it needs some work that I have no time to do now.
- Add a tool to rename ad unit, no architecture change. It's easier, but I have no time (because I don't need it, also), neither.

So, I leave this issue open for patches.

jcisio’s picture

jcisio commented

I revisit this issue and think that we don't need to change block delta. It's like when we can the delta of any Drupal block, it breaks connection to the block.

I suggest that you create superslot (whose the delta does not change), then add/remove ad units in those superslots as you want.

If we don't you ad unit name (or its md5), we need a relationship table to connect the name and the block delta. It complicates thing and I'm not ready to do it now.