See patch.

CommentFileSizeAuthor
#10 requirements-check-fails-on-drupal-installation-1215372-10.patch3.17 KBadammalone
#2 git_deploy.requirements.2.patch751 bytessun
git_deploy.requirements.0.patch1.17 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Also opened #1215376: Autoload and populate drupal_get_filename() with libraries.module during Drupal installation -- not sure which way to go. A general-purpose tweak in libraries.install might be preferable, but could also take some time.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new git_deploy.requirements.2.patch751 bytes

Requires patch of aforementioned issue.

Freso’s picture

Freso commented
Priority: Critical » Major
Status: Reviewed & tested by the community » Needs review

Do any install profiles add git_deploy currently? Regardless, it should definitely be fixed.

How to re-produce and test the patch? Also, is the problem specific to 6.x-1.x, or do we have it in 7.x-1.x too?

Freso’s picture

Freso commented

Also, how does this mingle with #1212942: Clean up git_deploy_requirements()?

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

subscribe

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Priority: Major » Critical
Status: Needs review » Reviewed & tested by the community

Patch in #2 works for me.

Bumping back to critical, as the drupalorg_testing profile uses this module, and won't allow people to install without this fix.

halstead’s picture

halstead commented
Status: Reviewed & tested by the community » Fixed

Pushed to 6.x-1.x. Thanks!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

@jhedstrom: Does that mean d.o relies on the Libraries API patch in #1215376: Autoload and populate drupal_get_filename() with libraries.module during Drupal installation now? (doesn't seem to be committed yet)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new requirements-check-fails-on-drupal-installation-1215372-10.patch3.17 KB

Just a 7.x update for the above patch as advised by this post.

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Status: Closed (fixed) » Needs review
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Issue summary: View changes
Related issues: +#2062763: Fix update.php missing version info from Git Deploy
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Needs review » Closed (outdated)

Requirements are no longer checked during installation.