Hi all,
took a quick look but couldn't find this listed as an issue though it is identified on ubercart.org: http://www.ubercart.org/forum/support/22159/ups_receiving_xml_response_q...

Essentially, according to the debug xml info, I am getting a successful return from UPS but no quote is being displayed and I am getting my standard quote error message.

I worked on the issue and turns out it was the fact that my set site currency was different from what was being returned by UPS. As a result, I wasn't getting into the if statement from line 929:

if (!isset($charge->CurrencyCode) || (string)$charge->CurrencyCode == variable_get('uc_currency_code', "USD")) {

Anyways, I tracked down the issue and fixed it but thought a patch might be in order to throw a more descriptive error when a site admin makes this type of mistake...

Comments

yaworsk’s picture

Probably a nicer way to do this as you have to refresh the page to see the error but hopefully a step in the right direction.

yaworsk’s picture

Opps,
ignore the previous patch -- accidentally patched version 7. Also, the reference to line 929 in the issue is incorrect, it is actually 839...

D6 patch attached.

longwave’s picture

Category: support » bug
tr’s picture

Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Needs review » Needs work

Isn't there a way to send tell UPS what currency you want to use for the rates? If so, we should implement that part of the API, rather than just throwing an error. The patch has some coding standards problems and isn't translatable.

New features should go into 7.x-3.x first.

longwave’s picture

Category: bug » support
Status: Needs work » Closed (fixed)

As this is such an edge case and only occurs when initially configuring UPS let's just close it out.