When I try to access a title without a theatrical release date I get:
Notice: Undefined index: theatricalreleasedate in theme_amazon_inline_item__dvd() (line 248 of /sites/all/modules/amazon/amazon_media/amazon_media.module).

It works when the title has one.

Comments

rfay’s picture

Thanks for your report.

If you can report the ASIN of the item that causes the warning it will make it much easier to fix this.

rfay’s picture

Title: Undefined index: When trying to access a title without theatrical releasedate » Remove Theatrical Release Date attribute

Well, the Theatrical Release Date has been removed from the current Amazon WSDL, http://aws.amazon.com/archives/Product-Advertising-API/8967000559514506

So I guess we just need to remove it all

rfay’s picture

Status: Active » Fixed
StatusFileSize
new5.73 KB

Committed the attached patch: 7230ee78bd7e5d22a5c9987938ad3dd18a0629d0

rfay’s picture

Version: 7.x-1.0-beta6 » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)

If somebody needs this for D6, just port the patch.

the_g_bomb’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new0 bytes

I've had a stab at the backport and think I got all references to theatricalreleasedate, theatricalreleaseyear and releaseyear, which seem to be the included in $variables at various points all relating to this. Wasn't a direct backport as the module has change dramatically between D6 and D7.

rfay’s picture

the_g_bomb++

hmt3design’s picture

There's 0 bytes in this patch - is the link wrong? Also, forgive the newbie question, but where would I paste it in?

the_g_bomb’s picture

Hopefully this patch is better

the_g_bomb’s picture

You need to have git installed to apply patches

Download the patch to your working directory, ideally to the folder with the amazon module files in it. Apply the patch with the following command:
git apply -v [patchname.patch]
in this case you would need to use:
git apply -v amazon-remove_theatrical_release_1216240_04.patch
you can then remove the patch file as that command applies the changes required to the module code files.

see http://drupal.org/project/amazon/git-instructions for more details about git instructions.

the_g_bomb’s picture

However the patch I have just supplied is for the D6 branch, your other issue sounds like your issue is with the D7 branch, is that correct? If so the code for that should be commited and already in the D7 code.

willvincent’s picture

Actually, you don't need to have git installed to apply a patch.

patch -p1 < [patchfile.patch]

Will work as well.

  • rfay committed 7230ee7 on 7.x-2.x
    Issue #1216240 by rfay: Fixed Remove Theatrical Release Date attribute.
    
    
  • rfay committed 75790c9 on 7.x-2.x
    followup: Issue #1216240 by rfay: Fixed Remove Theatrical Release Date...