Images do not get embedded correctly because media_flickr.theme.inc is pulling the URI from the wrong place when using the most current version of the Media modle. I've attached a patch that seems to correct the issue. This is the first patch I've made/contributed so if I've done it wrong, let me know.

Comments

Snugug’s picture

StatusFileSize
new607 bytes

Sorry, this is the correct patch. It needs to check if URI exists for when you are not trying to view the image from outside it's node and inside object->file when inside of a node.

dddave’s picture

The patch works when applied manually. I think you made some mistakes building it because I couldn't apply it with Cygwin.

dddave’s picture

Status: Active » Needs work

Just noticed that your patch is older than the newest version of this module. However I had the issue with the latest dev and applying the patch manually solved the problem (seemingly).

Snugug’s picture

Yah, I've never really rolled a patch before but thought I had followed the instructions correctly. Either way, I think it's something that should be put into the project.

dddave’s picture

Upgraded media module to the 7.2x branch and it seems the module doesn't work with it. So the patch works as reported above and I am going to create a new issue. :(

The usability in the new branch is a nightmare but after quite a while I figured it out. Module works and patch also (but still needs a re-roll).

ransom’s picture

...

Snugug’s picture

If you can point me to better instructions as to how to roll a patch I'll reroll

dddave’s picture

Snugug’s picture

Great, will update and reroll in a little bit

Yaazkal’s picture

Hello, I have:

File Entity 7.x-1.0-beta5
Media 7.x-1.0-beta5
Media Browser Plus 7.x-1.0-beta3
Media Internet Sources 7.x-1.0-beta5
Media: Flickr 7.x-1.0-alpha1
Media: YouTube 7.x-1.0-alpha5

I made the patch manually but nothing works. It just shows a link to Flickr. Any news about this?

Thanks

Leeteq’s picture

Is this patch needed now that Media 7.x-1rc is out?
(this issue seems to point to the main Media module being the source of the problem here)

Yaazkal’s picture

Hi, upgrated to Media 7.x-1.0-rc1 and media_flickr still not showing images... (with or without the patch).

Yaazkal’s picture

Hi, using media_flickr 7.x-1.x-dev the patch is not needed, the images are displaying (my problem was with media_flickr 7.x-1.x-alpha1)

Thanks

Leeteq’s picture

Status: Needs work » Fixed
cangeceiro’s picture

Status: Fixed » Needs work

I am also running into this issue running Drupal 7.8 and on the latest -dev branches of media and media_flickr. When I add an image the thumbnail is blank and viewing a node, no images show up.

mile23’s picture

Status: Needs work » Needs review
StatusFileSize
new636 bytes

Media:Flickr not very happy-making for me, either, with Drupal 7.8. The patch here didn't help me, but I rerolled it anyway. :-)

ianwremmel’s picture

I can confirm that I saw the bug using both the dev and near-stable branches of Media and Media: Flickr. The patch didn't seem to have any effect.

A partial solution seems to be that when adding the Flickr Media field to a content type, use Image rather than Multimedia Asset as the Field Type and use Media file selector as the Widget Type. This will allow flickr images to be shown on nodes however they will still appear as broken images in the media library. Note that this solution worked for the Media 7.x-1.0-rc1 and Media: Flickr 7.x-1.0-alpha1. I did not test that it works on the dev branches.

SilviaT’s picture

I tried the way suggested from ianwremmel and I got the same result: by using the Image field with the media file selector widget.
If I also specify the format of the field display as "Renedered file" in admin/structure/types/manage/article/display/default I get the error:

Notice: getimagesize() [function.getimagesize]: Read error! in image_gd_get_info() (line 349 of /modules/system/image.gd.inc).

jurgenhaas’s picture

I'm having the same issue with

- Drupal 7.12
- media_flickr 7.x-1.x-dev (2012-01-09)
- media 7.x-1.0-rc3

Jboo’s picture

Did anyone find out a fix for this?

jurriaanroelofs’s picture

seems like sets are working but single images not

30equals’s picture

First this wasn't working for me as well.
But my fix was rather simple:
-> goto: admin/config/media/file-types/manage/image/file-display
-> only enable 'image' & 'flickr preview image'

Before i had most of them checked (default settings).

jkingsnorth’s picture

#22 solved that my single images weren't displaying

Leeteq’s picture

Status: Needs review » Fixed

Maybe the short description in #22 should go into the readme.txt.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.