Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Jul 2011 at 13:52 UTC
Updated:
6 Feb 2012 at 19:39 UTC
Gives the user the option of automatically creating a new menu when a domain is created via the domain access module including options to set that menu as the primary or secondary links for that domain theme. Futher updates will also allow to user to set content type menu restrictions to the menu.
http://drupal.org/sandbox/omahm/1216020
Drupal 7.x
Comments
Comment #1
ccardea commentedI just took a quick look at your module.
.info file
files[] is for files containing class or interface definitions that get autoloaded. You don't need to include your .module file there.
You will need to include a README.txt file.
Licensing: No problems noted
Module duplication: Please post your research regarding any existing modules that may offer similar functionality.
The waiting time for a full review can be 4-6 weeks. You can help to reduce the waiting time by contributing to the code review process. Please visit http://groups.drupal.org/code-review for details on how to participate.
Comment #2
omahmI've removed the files[] statement (must read up on D7 changes ;P ) and included a readme file.
As for module duplication, domain navigation is similar but seemingly more complicated, and this module addresses that. It also makes the whole process of having unique primary or secondary links a lot quicker than manually creating menus, assigning to links source etc. Future versions will also allow you to choose which content types are assigned to the domain auto menu and a settings page will allow you to automatically enable or disable the creation of the menu and set the default theme links source for new domains. So to this extent, it is quite different from the domain navigation module.
Comment #3
klausi* a line in README.txt should not exceed 80 characters
* module file has no @file doc block http://drupal.org/node/1354#files
* why is domain_auto_menu_theme_defaults() empty?
* 4 newlines at the end of the module file, 1 should be enough
Comment #4
misc commentedThe applicant has been contacted to ask if the application is abandoned.
http://drupal.org/node/894256
Comment #5
misc commentedThe application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact