Closed (fixed)
Project:
Service links
Version:
6.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
12 Jul 2011 at 16:00 UTC
Updated:
2 Aug 2011 at 17:01 UTC
Jump to comment: Most recent file
Comments
Comment #1
f1mishutka commentedsubscr
Comment #2
TheCrow commentedsay me if that's wrong: if a foreign reader come to read your page the language is set on your lang (since you did it on the admin page), so we should use this plugin: http://plugins.jquery.com/project/localisation for an automatic recognition...
Comment #3
mean0dspt commentedTheCrow: not sure I understood your question. if language is not set, the way it is now, FB button code detects the browser or system language automatically and shows the button in this language.
but this creates theming problems: "like" has 4 letters (best button width 90px), in other languages equivalents can be 3-15 letters (up to 150px button width).
the width of button is set explicitly now and doesn't depend on the length of the used word. there's inconsistency in looks: wide margins or clipping. so some themers would prefer to set language explicitly too if their site uses only one language.
localisation project is used mostly for the sites with 2 or more languages used. this sites would probably prefer to leave &locale= blank for FB to autodetect and just set very big button width to avoid clipping. other solutions would be rather complicated
Comment #4
TheCrow commentedso the problem is the width of button... i thought the autodetection was not working anymore...
Comment #5
TheCrow commentedafter patch clean the cache!
Comment #6
mean0dspt commentedI checked the patch, and it works, but the
$vars['subst']['locale'] = strtolower($vars['subst']['locale']) . '_' . strtoupper($vars['subst']['locale']);looks wrong.why not simply allow input of normal 5-letter locale like es_AR, es_BR, pt_BR, pt_PT, en_EN, en_US etc.?
btw not every locale has first 2 letters equal to last 2 letters...
Comment #7
TheCrow commentedmodified!
Comment #8
mean0dspt commentedtested, works
as this is a rather simple patch, I suggest commiting it without further reviewing
thank you
Comment #9
TheCrow commentedcommitted also for 7.x-2.x!