Closed (fixed)
Project:
Viewfield
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Jul 2011 at 18:40 UTC
Updated:
4 Jan 2014 at 00:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sunHowever, let's make sure to do #1181226: Remove viewfield_views_query_alter() function first.
Comment #2
sunComment #3
sunLet's also do #1221440: Bogus default value in field widget first, since that is touching surrounding functions.
Comment #4
sunAttached patch removes the /theme directory and performs many (but not all) changes discussed in #1071212: Fix viewfield rendering.
The argument parsing functions are merely moved without changes.
Comment #5
sunRe-considered. Let's just do the code reshuffling here.
Comment #6
keithm commentedBecause #1071212: Fix viewfield rendering requires this and since it's just a code shuffle, I'm going to commit this shortly if you don't :)
Comment #7
sunThanks for reporting, reviewing, and testing! Committed to 7.x-2.x.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
Guess it would make sense to backport this for easier cross-version diffs... (?)
Comment #8
keithm commentedFor 6.x-2.x.
Comment #9
sunodd, this file doesn't exist yet, according to http://drupalcode.org/project/viewfield.git/tree/refs/heads/6.x-2.x ...?
Let's move theme_viewfield_select() below viewfield_theme() -- not in between widget functions.
Speaking of, viewfield_theme() needs to be adjusted for the include/file path.
Comment #10
keithm commentedIt's buried in the theme directory.
Rerolled.
Comment #11
sunThanks, looks good.
Though the patch doesn't contain ./viewfield.css at all anymore now -- let's make sure we don't lose it ;)
Comment #12
keithm commentedThanks. The latest patch was created without viewfield.css because I did a straight git diff during a staging/stashing inconsistency. Committed correctly though: http://drupalcode.org/project/viewfield.git/commit/c03b694.