This module provides a lightweight mechanism for theme authors to specify which fonts should be loaded via Google Font API. It is an alternative to the Google Font API module (http://drupal.org/project/google_fonts). This module is considerably smaller in scope and doesn't require an administration interface. It is meant to be used exclusively by theme developers.

Link to the sandbox project page: http ://drupal.org/sandbox/mark.wise/1184038

Comments

mark.wise’s picture

mark.wise commented
Status: Active » Needs review
mark.wise’s picture

mark.wise commented
Priority: Normal » Major

I'm still waiting on an initial response from the reviewer. I'm eager to contribute other modules, so please let me know. Thanks.

pillarsdotnet’s picture

pillarsdotnet commented

I like the concept. Some initial comments:

  1. Lose the LICENSE.txt file -- it will automatically be added by the Drupal packaging system.
  2. Please run this through coder review if you haven't already.
  3. Please port this to 7.x so I can actually use it.
sreynen’s picture

sreynen commented
Status: Needs review » Postponed

I think this should wait on a response to mark.wise's request to have this functionality included in the existing Google Fonts module. If the functionality gets added there, the only motivation for this module seems to be that it's simpler, which is explicitly rejected as a good motivation for new modules. If the existing Google Fonts module is too complicated, we should collaborate to make it simpler.

If this functionality doesn't work out for some reason in Google Fonts, I'd also be happy to work with mark.wise in @font-your-face, where I have an open issue to add the same functionality.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

It seems the issue to add this to Google Fonts is dead. I wonder if Mark should take over that project?

Mark, you mentioned you have other projects. Maybe you could apply based on one of those?

Thanks!

pillarsdotnet’s picture

pillarsdotnet commented

According to the project page, the Google Fonts maintainer pushed a commit 11 weeks ago. Are you sure he has abandoned the project?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

@pillarsdotnet - I said "I wonder" but my basis for judging the status was the lack of followup on http://drupal.org/node/970922#comment-3721978

I don't really know what should happen here, but I want to help Mark to contribute and I want to help move this issue out of "postponed."

@mark.wise - what are your thoughts?

sreynen’s picture

sreynen commented

Sorry, I should have followed up on this sooner. Since I suggested adding this functionality to the Google Fonts module, I've talked more with BarisW, the maintainer of the Google Fonts module, and he's working on @font-your-face to prepare it to eventually transition Google Fonts users to @font-your-face.

So Google Fonts isn't abandoned, but it's also probably no longer the most useful place to add this functionality. I think @font-your-face is the best place to put this now, and as maintainer of @font-your-face, I'd love to help get it added there.

mark.wise, how do you feel about working together on getting this functionality into @font-your-face rather than keeping this a separate project?

sreynen’s picture

sreynen commented

Hi mark.wise,

Any update on this? Baris is starting to work on this functionality in @font-your-face now.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed » Closed (won't fix)

There have not been replies in the past months.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Made the sandbox link clickable.