Here is a patch implementing a bunch of coding standards-related changes to make the Coder module happy. Unless I made a mistake, this has no functional changes.

CommentFileSizeAuthor
#3 accessible_coding_standards_1216900.patch54.72 KBliam morland
accessibility_fix_code_review.patch43.84 KBliam morland

Comments

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs review » Needs work

Sorry, no longer applies.

Liam, are you using your patched version of the code in your development process?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Liam, are you using your patched version of the code in your development process?

Possibly; it was a long time ago. It's hard not to since my editor removed end-of-line whitespace automatically. How about I re-roll this one and do the others after it is committed?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new accessible_coding_standards_1216900.patch54.72 KB

Here is a big patch fixing mostly whitespace issues. Should be no functional change. Not every issue found by Coder is fixed, but it is a start.

mgifford’s picture

mgifford
he/him
Primary language English
commented

Thanks so much Liam!

What did you apply this to? I had problems applying it to the git master repository.

It's definitely a start, and one I hope to roll into an update if I can.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

The patch is against the 7.x-2.x branch. Drupal.org git repositories are not supposed to have master branches.