Comments

jacine’s picture

Issue tags: +html5, +Front end

Tagging.

johnvsc’s picture

Issue tags: -html5, -Front end +HTML5 Sprint: July 2011 - 2

adding tags

johnvsc’s picture

Title: Clean up the Block Module CSS for HTML5 » Clean up the CSS for Block module
Issue tags: -HTML5 Sprint: July 2011 - 2 +html5, +Front end
jacine’s picture

Issue tags: +HTML5 Sprint: August 2011 - 1

Tagging!

aspilicious’s picture

Status: Active » Needs review
StatusFileSize
new2.31 KB

This is harder than I suspected...
It's not rly clear what belongs to the base.css.
I tried something.

aspilicious’s picture

Status: Needs review » Needs work

This needs to be called somewhere:
Here all all the links to block.css

modules\block\block.admin.inc
      12    drupal_add_css(drupal_get_path('module', 'block') . '/block.css');
      80    drupal_add_css(drupal_get_path('module', 'block') . '/block.css');

do we need to call both files?

aspilicious’s picture

Aad I just tried to disable *every* css line and it still looks good in stark. So we don't need the base file here.

aspilicious’s picture

Status: Needs work » Needs review
StatusFileSize
new5.07 KB

Ok ow I understand what we are trying to do :).
Attached patch with new approach, the theme specific stuff needs to be looked at carefully.

aspilicious’s picture

StatusFileSize
new5.08 KB

Hmmm actually we don't need to load the css anymore in the region page.

aspilicious’s picture

Status: Needs review » Needs work
+++ b/themes/seven/style.cssundefined
@@ -994,3 +994,38 @@
+#blocks tr.region-title td {
+  font-weight: bold;
+}
+#blocks tr.region-message {
+  font-weight: normal;
+  color: #999;
+}
+.block-region {
+  background-color: #ff6;
+  margin-top: 4px;
+  margin-bottom: 4px;
+  padding: 3px;

I'm not sure we need to rip this out of core block and place it in every theme.

This leads to duplication. I do think we should move the block demo styling as it looks bad in stark. But maybe we can leave some basic styling. I don't know...

22 days to next Drupal core point release.

rupl’s picture

Status: Needs work » Needs review
StatusFileSize
new3.29 KB

I feel like we should use the same approach as #1216976: Clean up the CSS for Comment module when patching this module.

Styles — especially the administrative styles in block.css — need to live in this module's directory, not duplicated amongst the core themes (and any active theme wanting to use block demonstration mode). It seems appropriate to relocate all of these styles to block.admin.css.

This patch renames block.css to block.admin.css, and fixes drupal_add_css() calls within block.admin.inc. I tested against Bartik, Garland, and Stark block admin/demo pages.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Other than splitting into block.admin.theme.css and block.admin.base.css... :) This is great.

Status: Reviewed & tested by the community » Needs work
Issue tags: -html5, -Front end, -HTML5 Sprint: August 2011 - 1

The last submitted patch, 1216950-block-css-cleanup-11.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review
Issue tags: +html5, +Front end, +HTML5 Sprint: August 2011 - 1

#11: 1216950-block-css-cleanup-11.patch queued for re-testing.

jacine’s picture

Issue tags: +HTML5 Sprint: August 2011 - 2

Adding current sprint tag :)

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

See #12 still rtbc, bot hickup

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jacine’s picture

Component: block.module » CSS
Issue tags: -Front end, -HTML5 Sprint: August 2011 - 1, -HTML5 Sprint: August 2011 - 2

Cleaning up tags/component.

oresh’s picture

Status: Closed (fixed) » Needs review
StatusFileSize
new1.32 KB

Even more clean up for the latest build.

xjm’s picture

Status: Needs review » Closed (fixed)

Create a new issue.