Part of the CSS Cleanup: http://drupal.org/node/1089868
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | 1216950-by-oresh-CSS-cleanup-for-block-module-20.patch | 1.32 KB | oresh |
| #11 | 1216950-block-css-cleanup-11.patch | 3.29 KB | rupl |
| #9 | 1216950-split-block-css-9.patch | 5.08 KB | aspilicious |
| #8 | 1216950-split-block-css-8.patch | 5.07 KB | aspilicious |
| #5 | 1216950-split-block-css.patch | 2.31 KB | aspilicious |
Comments
Comment #1
jacineTagging.
Comment #2
johnvsc commentedadding tags
Comment #3
johnvsc commentedComment #4
jacineTagging!
Comment #5
aspilicious commentedThis is harder than I suspected...
It's not rly clear what belongs to the base.css.
I tried something.
Comment #6
aspilicious commentedThis needs to be called somewhere:
Here all all the links to block.css
do we need to call both files?
Comment #7
aspilicious commentedAad I just tried to disable *every* css line and it still looks good in stark. So we don't need the base file here.
Comment #8
aspilicious commentedOk ow I understand what we are trying to do :).
Attached patch with new approach, the theme specific stuff needs to be looked at carefully.
Comment #9
aspilicious commentedHmmm actually we don't need to load the css anymore in the region page.
Comment #10
aspilicious commentedI'm not sure we need to rip this out of core block and place it in every theme.
This leads to duplication. I do think we should move the block demo styling as it looks bad in stark. But maybe we can leave some basic styling. I don't know...
22 days to next Drupal core point release.
Comment #11
ruplI feel like we should use the same approach as #1216976: Clean up the CSS for Comment module when patching this module.
Styles — especially the administrative styles in block.css — need to live in this module's directory, not duplicated amongst the core themes (and any active theme wanting to use block demonstration mode). It seems appropriate to relocate all of these styles to block.admin.css.
This patch renames block.css to block.admin.css, and fixes
drupal_add_css()calls within block.admin.inc. I tested against Bartik, Garland, and Stark block admin/demo pages.Comment #12
tim.plunkettOther than splitting into block.admin.theme.css and block.admin.base.css... :) This is great.
Comment #14
aspilicious commented#11: 1216950-block-css-cleanup-11.patch queued for re-testing.
Comment #15
jacineAdding current sprint tag :)
Comment #16
aspilicious commentedSee #12 still rtbc, bot hickup
Comment #17
dries commentedCommitted to 8.x. Thanks.
Comment #19
jacineCleaning up tags/component.
Comment #20
oresh commentedEven more clean up for the latest build.
Comment #21
xjmCreate a new issue.