Clean up the CSS for Menu module

First patch to try to clean up Menu module css.

Honestly, I think that we could just remove all of the menu css. There are only three styles in the menu.css file and they only make small changes to table column and cell contents sizes (which are best determined by the browser anyway).

There is almost no difference in presentation between using the styles and removing them.

.menu-operations {
  width: 100px;
}

Sets the size of the table cells which have the "edit" and "delete" buttons inside of them to 100px.

• I see no reason for these cells to be any larger than the text that they contain.
• A width isn't specified for other delete links like the ones on the content type page (admin/structure/types).
• If the words "edit" and "delete", when translated into another language, are longer than 100px, the style does nothing.

.menu-enabled {
  width: 70px;
}

Sets the size of the table cells which have the "enabled" checkbox inside of them to 70px.

• There is also no reason for these to have a specific width defined.
• The width isn't specified for other enabled checkboxes like the ones on the modules page (admin/modules).

.menu-enabled input {
  margin-left:25px;
}

Adds 25px to the left of input checkboxes which are located inside of the "enabled" checkbox table cells.

• There is no reason to have an arbitrary amount of spacing added to the checkboxes.
• Checkboxes located in table cells are automatically centered. The margin ruins the centered positioning.
• Margins are not added to checkboxes added on other pages such as the modules page (admin/modules).

Attached are two images: a before (with the styles) and an after (with the styles removed).

And a patch to remove the css file and the lone reference to it.

I disagree a bit.

This is unneeded. It looks even better without it.

.menu-enabled input {
  margin-left:25px;
}

But

.menu-operations {
  width: 100px;
}

and

.menu-enabled {
  width: 70px;
}

should stay.

We can leave it in admin.css or we can move it to bartik and seven.

I've rerolled the patch and only removed .menu-enabled input.

Anyway the file name should change. We have to move this to menu.admin.css. (see summary)

Looks like the patch in #5 needs some love. I'll see if I can make some headway tonight.

Looks like the patch in #5 needs some love. I'll see if I can make some headway tonight.

Here's a patch that rerolls #5, renames the css to menu.admin.css, and makes the appropriate change to menu.admin.inc

Just tested this, looks good :)

Tagging with coding standards, for Jennifer to take a look at.

I was going to say this needed to be delayed due to being over threshold on critical tasks right now, but it's such a small patch (one line of code and the rest is CSS), I went ahead and committed it anyway. I don't think it will affect any other issues (hopefully). Thanks!

I'm not usually one to disagree but I think that this should have been looked at a bit more closely.

I outlined some valid concerns in #2 which were only addressed, without explanation, by "but x and y should stay" in #4. I also provided screenshots which show that there is no benefit provided by the rules; they only provide inconsistency with other administration pages and introduce an unnecessarily large amount of white space.

Many of the core administration pages use a table with a row of "operations" links, such as:

• Content types
• Menu management
• Taxonomy
• Blocks
• Modules
• People

The menu management page is the only page in Drupal core that places a class on the table column (except for the modules page which uses the class for creating icons). It is also the only place where a defined width is applied to the operations column.

Lets say you are building an administration theme and want to modify the width of table cells, such as by restricting all cells to a maximum width by doing something like:

table td {max-width: 200px;}

This would work fine for every single table in core, except for the menu management table, since it specified its own width. Inconsistencies like this make theme developers, such as myself, sad. :(

Is there a good reason for keeping these rules? I also think the table classes should be gone, or those classes should be applied to operations links on every administration page (a separate issue).

If you're concerned please collect some links to tables in the drupal admin interface and I'll look at them and make a proper response and maybe kill those lines if you're correct.

I don't have a problem with removing menu.admin.css, but those styles should definitely go into Seven and Bartik if it's removed.

Updated issue summary.

Updated issue summary.

Start working on that

Start working on that

Changes from #9 are already applied in the last commit:
- removed .menu-operations because it is not such class
- correct path for menu.admin.css

Marking as fixed because CSS is already cleaned and we will be able to close the hole #1921610 issue. Feel free to open a new issue to discuss any other topic related.