Clean up the CSS for User module

gimme...

+++ b/modules/user/user.theme.cssundefined
@@ -0,0 +1,69 @@
+/* Generated by user.module but used by profile.module: */

Can't it move to profile.module?

21 days to next Drupal core point release.

the only thing this issues is about & this patch is doing moving the css files in so we can begin to use the bat name scheme.
to begin trying to fix all kinds of other problems isnt the role of this issue if its a problem that should be looked at i think you should open up a new issue

Profile module doesn't exist, so related code should be removed.

But, this issue and all of these aren't just about moving CSS and changing file names. We need to really get deep into the CSS, and the markup, if necessary and fix problems with the code. I am going to work on better instructions for what's going on in these issues and provide summaries.

Just tested the patch by @mortendk in #3. This is my feedback and summary of the new patch:

- The comment /* Generated by user.module but used by profile.module: */ is incorrect. The class .profile is added by the User module in user-profile.tpl.php. I updated the comment in the css to make this clear.
- The border under the .profile h2 seems useless, so that's been removed.
- The file user.css was empty but still present, so completely removed that one.
- Moved some css from user.theme-rtl.css to user.base-rtl.css since that css was overwriting css in user.base.css.
- added some margin to .password-strength to reflect the margin on .password-confirm.
- removed some more divs.

One more question for @mortendk: why was some of the css duplicated in Bartik?

+++ b/modules/user/user.theme.cssundefined
@@ -0,0 +1,64 @@
+  margin-top: 1.5em;  ¶

trailing whitespace

+++ b/themes/bartik/css/style.cssundefined
@@ -1083,6 +1083,54 @@ div.password-confirm {
+
+
+
+
+
+

Way to much line breaks

Those duplicated css lines in Bartik should be removed

-28 days to next Drupal core point release.

And the profile stuff needs to be removed

A new patch will be posted tomorrow that removes the trailing whitespaces and the Bartik changes.

As mentioned earlier, the .profile css is added and used by the user module so I don't see why this should be removed?

is it possible to remove td.class, tr.class, div.class ?

Here's a list of updates that can be found in the new patch:

- Rerolled against the new /core folder
- alphabetized all properties
- removed trailing white-space and other small spacing errors
- to avoid confusion and/or clashing with the profile module, I've changed the .profile class to .user-profile.
- removed this css since it no longer reflects the HTML cleanup in other patches:

.user-profile dl {
  margin: 0 0 1.5em 0;
}
.user-profile dt {
  font-weight: bold;
  margin: 0 0 0.2em 0;
}
.user-profile dd {
  margin: 0 0 1em 0;
}

- the user.admin.css was no longer included on the permissions and roles page after applying the patch.
- Removed this unnecessary css for the Account settings page:

#user-admin-settings .fieldset-description {
  font-size: 0.85em;
  padding-bottom:.5em;
}

- remove td/tr from selectors where possible
- added file headers
- other small fixes :)

Ultra quick dreditor scroll review

+++ b/core/modules/user/user.admin.cssundefined
@@ -0,0 +1,32 @@
+ * User roles form. ¶

trailing whitespace

-21 days to next Drupal core point release.

Two updates:

- Trailing white-space removed
- The RDF-test has been updated to reflect the switch from .profile to .user-profile.

+++ b/core/modules/user/user.infoundefined
@@ -7,4 +7,5 @@ files[] = user.entity.inc
-stylesheets[all][] = user.css
+stylesheets[all][] = user.theme.css
+stylesheets[all][] = user.base.css

This loads this css on every page, seems like overkill... I think we can include it when we need it. When thats done we can remove these lines. Less crap in .info files++

Second thingie: this all seems admin css, so why is it inside theme.css? I tested the css and it looks great. So I can rtbc when my concerns are fixed or when someone proves me wrong.

-22 days to next Drupal core point release.

speaking of unwanted design assumptions on the theme layer, do we really need to be floating the profile photo?

it has caused problems in the past due to a lack of clearing.. seems like something a theme should handle, not a module.

#67523: Looking at the user list the user picture stick out of the border

on my list for tonight

In this patch I:

• removed user.base.css and user.theme.css from the .info file
• made an effort to find all the places where I would need to include the user.base.css and user.theme.css files and used #attached to include them
• modified the css so the user pictures aren't floated.

I'm unsure if I found all of the places where I need to include the css. Can someone please review this?

Forgot the attach the patch.

not entirely sure not floating the user photo is the right approach, (especially for the solution in d7) just wanted to bring it up for discussion.

I suppose the floating user picture issue is weakened by the fact that we have that code in the user.theme.css file, which allows themers to simply turn off that file if they don't like the floating.

great point, moving to theme.css resolves the concern from a themers perspective

& since the "History" H3 element with the border is no longer present in D8, the D7 issue has no bearings really.

ok, then I'll revert the removal of float from my patch in #20 (but I won't have an opportunity to do this until tonight.)

We hava to make sure the password css still works in every case (installation and changing password)

The patch from 20 no longer works with the latest git version.

I hand copied the changes and ran a new patch. Hopefully I caught everything.

Rerolled the patch. Hope everything is right.

+++ b/core/modules/user/user.admin.cssundefined
@@ -0,0 +1,30 @@
+#permissions .module {
+  font-weight: bold;
+}
+#permissions .permission {
+  padding-left: 1.5em; /* LTR */
+}
+#permissions .odd .form-item,
+#permissions .even .form-item {
+  white-space: normal;
+}
+#user-admin-settings .details-description {
+  font-size: 0.85em;
+  padding-bottom: .5em;

These selectors don't seem to be inline our new SMACSS style guidelines. These selectors seem unnecessarily strong

Ok, I fixed the css files folder and the #permissions id, but I don't find where is the #user-admin-settings id defined.

add meta issue it belongs to

Updated summary to the latest CSS organization guidelines.

Re-rolled with the latest changes in 8.x branch.

Starting to work on this.

This issue is continued in the https://drupal.org/node/2030539.

Closing.

Consensus was reached in both http://drupal.org/node/1921610 and at DrupalconPDX discussions that using "theme" over "skin" in the CSS class renaming effort is more straight-forward.