Attached a patch which solves the todo in the audio module:

Line 418: // TODO: should these links be by vid?

I think it is a pretty elegant solution but some review might be nice.

CommentFileSizeAuthor
#3 audio_download_revision_0.patch1.5 KBtoemaz
audio_download_revision.patch1.5 KBtoemaz

Comments

drewish’s picture

drewish commented
Status: Active » Needs work

humm, i don't really like the way it's structured. rather than parsing arg()s it should be done via the menu system. also, why did you rename audio_download() to music_download()?

toemaz’s picture

toemaz commented

rather than parsing arg()s it should be done via the menu system

Can you point me in the right direction? I'm not quite sure what you mean.

also, why did you rename audio_download() to music_download()?

Sorry my mistake! It wont happen again ;-)

toemaz’s picture

toemaz commented
StatusFileSize
new audio_download_revision_0.patch1.5 KB

Is it possible to elaborate what you ment in your first follow up drewish?

In the meantime, here is the correct patch