Hi there,

For project specific regions I needed to display a view of users which naturally have their profiles attached. Because of the nature of this view listing page, I was looking to have a sort of user teaser view mode active so I wouldn't get the full profile. Unfortunately even if I created a teaser view mode for users the full profile would still come through because there is no relationship there. I'm submitting a feature request to have profile entities inherit the view modes of their users. This addition will still allow profiles to be displayed on their own but will give admins much greater control on the display of user entities also (with profiles).

CommentFileSizeAuthor
#13 inherit-user-view-modes--1218232-13.patch1.34 KBmpgeek
#10 profiles_inherit_user_viewmodes-1218232-10.patch966 bytessmithmilner
#8 profiles_inherit_user_viewmodes-1218232-8.patch1.13 KBsmithmilner
#5 profiles_inherit_user_viewmodes-1218232-5.txt1.13 KBsmithmilner
#2 profiles_inherit_user_viewmodes-1218232-2.patch1.26 KBsmithmilner
#1 profiles_inherit_user_viewmodes-1218232-1.patch1.13 KBsmithmilner

Comments

smithmilner’s picture

smithmilner commented
Issue tags: +inherit, +view modes
StatusFileSize
new profiles_inherit_user_viewmodes-1218232-1.patch1.13 KB

This is still a ways from complete but it works!

smithmilner’s picture

smithmilner commented
StatusFileSize
new profiles_inherit_user_viewmodes-1218232-2.patch1.26 KB

I've found that view modes can be missing depending on profile2's order in the hook_entity_info_alter(). This is stab in the dark to try and get a final result on the user entity.

smithmilner’s picture

smithmilner commented

hello?

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs work

Sounds good to me, the hack in the entity-info-alter hook is very ugly though. I think just inheriting the view-modes that are available during alter should do it - if someone adds one in after us, he can do it for profile2 too.

smithmilner’s picture

smithmilner commented
StatusFileSize
new profiles_inherit_user_viewmodes-1218232-5.txt1.13 KB

Ok, we'll go back to the first version of the patch to avoid ugly hackyness. Another small issue here is that users have a view mode called "full" which for all purposes is identical to profile2's view mode "account". After the profile2 inherits user view modes we end up with a duplicated view mode as seen in the second screenshot. I think it would be ideal to change the machine name of profile2's view mode to be "full" so it's inline with users. I haven't thought about what sort of implications that might have, what do you think?

user view modes: https://skitch.com/smithmilner/gc9au/welcome-to-participedia-participedia

profile2 view modes(after patch): https://skitch.com/smithmilner/gc9ab/welcome-to-participedia-participedia

langworthy’s picture

langworthy commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, profiles_inherit_user_viewmodes-1218232-2.patch, failed testing.

smithmilner’s picture

smithmilner commented
Status: Needs work » Needs review
StatusFileSize
new profiles_inherit_user_viewmodes-1218232-8.patch1.13 KB

aha, editor renamed it to .txt. Let's try this again...

Status: Needs review » Needs work

The last submitted patch, profiles_inherit_user_viewmodes-1218232-8.patch, failed testing.

smithmilner’s picture

smithmilner commented
Status: Needs work » Needs review
StatusFileSize
new profiles_inherit_user_viewmodes-1218232-10.patch966 bytes

Rerolled against dev.

kevinquillen’s picture

kevinquillen commented

That patch worked for me! Went in circles for two hours on this.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work 
+++ b/profile2.module
@@ -93,6 +93,17 @@ function profile2_entity_info() {
+ * profile2 entity inherits view modes from users

Should start capitalized and end with a point, in short it should be a full sentence.

+++ b/profile2.module
@@ -356,7 +367,7 @@ function profile2_user_view($account, $view_mode, $langcode) {
-        $account->content['profile_' . $type]['view'] = $profile->view('account');
+        $account->content['profile_' . $type]['view'] = $profile->view($view_mode);

This is changes the view-mode which is used by default, which might break people's settings.

Thus, we cannot change the default view-mode. Maybe just go with 'account' for view mode "full" and pass through others.

mpgeek’s picture

mpgeek commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new inherit-user-view-modes--1218232-13.patch1.34 KB

Here is another version with a more general approach that takes into account the fact that default view mode for profile2 is account that is associated with the full view mode for user, as pointed out in #12. A more general approach would likely be to implement view modes along the lines of the way entity reference provides display mode configuration when attaching to another entity.

sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented

Applied the patch and it seems to be working for me - thanks! :)

rickj’s picture

rickj commented
Status: Needs review » Closed (duplicate)
Related issues: +#2148375: Displaying a profile with a specific view mode

Closed as duplicate of #2148375: Displaying a profile with a specific view mode. The actual code fix is a one-liner, there is no need to map 'full' to 'account'.

If a view mode doesn't exist the display falls back to the default. The system displays the regular user account page using view mode 'account', but there is no need to preclude adding 'full' as another view mode for other purposes.