PHPBB 3.0.9 was released July 10th.

(not sure which "version" this was best to file under?)

Thanks in advance vb!

CommentFileSizeAuthor
#6 phpBB-embed-3.0.9.patch64.45 KBpotss

Comments

demon326’s picture

Works with 3.0.9 and should work untill 3.1.0(new major version in a year or two)

aitala’s picture

Hi,

Any advice on how to do the phpBB upgrade or will its normal update script work?

Eric

vb’s picture

the 3.0.9 will be ready on this weekend, so please wait till monday.

parasolx’s picture

Status: Active » Needs review

the 3.0.9 is already come out. i'm checking what diff and changes done by phpBB team. looks like there is a changes in functions_user.php files which they remove these code line:

			}

			$sql = 'SELECT topic_id, COUNT(post_id) AS total_posts
				FROM ' . POSTS_TABLE . "
				WHERE poster_id = $user_id
				GROUP BY topic_id";
			$result = $db->sql_query($sql);

			$topic_id_ary = array();
			while ($row = $db->sql_fetchrow($result))
			{
				$topic_id_ary[$row['topic_id']] = $row['total_posts'];
			}
			$db->sql_freeresult($result);

			if (sizeof($topic_id_ary))
			{
				$sql = 'SELECT topic_id, topic_replies, topic_replies_real
					FROM ' . TOPICS_TABLE . '
					WHERE ' . $db->sql_in_set('topic_id', array_keys($topic_id_ary));
				$result = $db->sql_query($sql);

				$del_topic_ary = array();
				while ($row = $db->sql_fetchrow($result))
				{
					if (max($row['topic_replies'], $row['topic_replies_real']) + 1 == $topic_id_ary[$row['topic_id']])
					{
						$del_topic_ary[] = $row['topic_id'];
					}
				}
				$db->sql_freeresult($result);

				if (sizeof($del_topic_ary))
				{
					$sql = 'DELETE FROM ' . TOPICS_TABLE . '
						WHERE ' . $db->sql_in_set('topic_id', $del_topic_ary);
					$db->sql_query($sql);
				}

these line is also in phpbbforum hack code. since new version only remove these function, I will try to update all the file first. will update later the result.

parasolx’s picture

finish updating my phpBB by using Automatic Updates. Look everything goes alright form start until finish updating all files. for my forum, I enable the debug mode in config.php which turn a display error at top of page.

this issue I already post before: #1036256: PHP Notice: in file /includes/functions.php on line 4316 but until now there is no action regarding about that.

the main purpose of phpBB team remove above code because there is a conflict that number of post does not correctly update when a user is being deleted. by removing code above, phpBB add another code to synchronize the number of post.

so i think, comment the bunch of code in phpbbforum hack code would not give any effect since new code add in is not in user remove case in functions_user.php

potss’s picture

StatusFileSize
new64.45 KB

my first version patch to phpbb3 3.0.9
http://www.drupal.ru/node/65462

fizk’s picture

Status: Needs review » Closed (fixed)