A very good module! However some improvements may be suggested, such as:

Display the translate button in a block instead on top of node/comment
this can solve the next proposal: Displaying the button only with certain node-types, roles or pages …
or, alternatively, a translatable region setting option to limit display to certain node types

On layout level - if there is no block solution - it may look better if the button can also be displayed right top and/or left/right bottom

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Interesting - I'm so glad you're using it.

I don't understand how you could display the translate button in a block, since it targets a CSS selector. How could the block be properly placed in that case? I guess it could have a specific node or comment behavior in addition to targeting a CSS selector, but right now it just targets CSS.

You already have complete control of what kinds of content it displays on. That's determined by the CSS selector.

And I would think you could change the display with a bit of CSS, but I haven't thought about that.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Interesting - I'm so glad you're using it.

I don't understand how you could display the translate button in a block, since it targets a CSS selector. How could the block be properly placed in that case? I guess it could have a specific node or comment behavior in addition to targeting a CSS selector, but right now it just targets CSS.

You already have complete control of what kinds of content it displays on. That's determined by the CSS selector.

And I would think you could change the display with a bit of CSS, but I haven't thought about that.

choy’s picture

choy commented

For sure the display of the button could be changed when screwing a little bit individually in the theme css - but better would be surely a hook solution with an ui to decide wheter right/left top/bottom …
concerning the node-type recognition (to display the button only on certain node-types) I only know the block solution, (which doesn't work in this case) - if there are other solutions - even better -
To my opinion the module solves in a good way the multilingual solution, when people are offered to read in any defined language content not always translated on the site and some of those languages they only know basicly.
Hoewever it would be good if the translate button can be limited to certain content types... and not only by individual decision as it is now ...

choy’s picture

choy commented

PS I want to use your module to ease my users with some exotic languages the translation of short adverts - for longer and esential text like "about us" and other the google translations are still not very useful ... that's why I propose a button configuration by node type ...