Stabilize fullcalendar (colors) api for beta release

Changing status

This patch adds array type hinting

This is maybe a better idea. Code probably doesn't work because of the ctools plugins.

I used css_selectors to proove a point, name is debatable.

After discussion with timplunkett 10 days ago and some thinking on my vacation I come with this solution. This splits the fullcalendar_classes hook and the fullcalendar_colors_class_names hook.

hook_fullcalendar_class
Is a hook for adding css classes to the fullcalendar event. You can use the entity to decide which classes to add.

*** IMPORTANT CHANGE ***
If fullcalendar colors is enabled every classname that has a color configuration in the color database will be colored.

hook_fullcalendar_colors_class_names
Collects additional classes for coloring that are NOT in the classes array of the fullcalendar event.

*** IMPORTANT CHANGE ***
Classes that are alrdy added with the hook_fullcalendar_classes DO NOT need to be added again with the fullcalendar_colors_class_names hook.

These changes give the needed flexibility to developers AND prevent duplication of code.

Sidenote: this issue does not try to move more code to the colors module. That's a different issue that needs more discusion. This issue tries to stabilize the api for a beta release.

Retiteling.

Just a note: when I was writing the patch I wondered if I should use module_invoke_all or the construction I'm using now (same as we alrdy have in the fullcalendar colors module). I thought my code was ugly but aparantly for this use case this is the correct solution. See http://drupal.stackexchange.com/questions/8159/is-it-better-to-use-modul...

Changed info

Many ==> much

Adding tag

Ok new tested and finished patch. Assigning to the boss for a review.

Couple of ways to test this:
1) Look at the code
2) Test if coloring still works as expected

3) THA AWESOME STUFF

- add a specific classname to a gcal field
- install fullcalendar_colors_classname module
Instructions ==> http://drupal.org/node/1175528/git-instructions/classnames/nonmaintainer
- update colors module to latest dev
- create a color configuration for the new gcal class in the UI
- LOOK AT THE PRETY COLORS!!!

Sidenote:

Text coloring is failing because

/* Undo Drupal default theme link colors */
.fc-content a:link,
.fc-content a:visited {
  color: #fff;
  text-decoration: none;
}

is to specific... in fullcalendar.theme.css

If you can help me with that, we can close this topic.

Forgot patch...

Bumping this to the top of my list.

Tim could you review the code for this after the others got in?
(don't look at the trailing whitespace issues)

Probably needs a reroll.

Ok I rerolled the patch.

1) Download the "to-merge" branch and see if you can upgrade to that one, its possible that things brake due to missing handlers, but after runnin update.php and clearing caches everything is fine again

2) Install this patch

3) Install fullcalendar_colors_classname module
Instructions ==> http://drupal.org/node/1175528/git-instructions/classnames/nonmaintainer

4) update colors module to latest dev

5) Create a new color configuration in the colors UI. (you need firebug or chrome development tools to check the date class name added to the event, that classname is the selector you need)

If you need more help I'm sometimes available on irc in the #fullcalendar channel

Ok lets make it easier to test this :)

Download the attached zip file.
- It contains a modified fullcalendar module (based on alpha 7 so run update.php when upgrading)
- It also contains the "fullcalendar colors classname" module

Add some events containing a date field. Search for the date field classes added for a specific event.
In my test setup I created a date field named "field_datum". Fullcalendar module inserted the "fc-event-field-field_datum" class for this field. (see image)

When you know the field name you can insert it into the UI and color it

Afterwards everything should be fine :)

If it wasn't clear, I'm done with coding.
I fixed a couple small bugs while testing so I think it's bugfree.

I see I alrdy assigned it to you :)

The fieldname stuff is an example module to proof you can color based on the output of a select field.
I renamed to fullcalendar_colors_classnams_example but forgot some things :)

This example module won't be included in the final product. Probably will place it on a doc page.

The thing needs a code review from Tim Plunkett and he decides what gets in and what has to be rewritten :)
So we have to be patient :).

If he is happy this will be merged into the next release

PARTY!! now I can make my first real module =D