Posted by sugree on February 23, 2007 at 8:34am
4 followers
| Project: | Tagadelic |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | sugree |
| Status: | closed (fixed) |
Issue Summary
=== modified file 'tagadelic.module'
--- tagadelic.module 2007-02-23 08:24:13 +0000
+++ tagadelic.module 2007-02-23 08:24:47 +0000
@@ -316,7 +316,7 @@
if ($op == 'view') {
if ($voc = taxonomy_get_vocabulary($delta)) {
$blocks['subject'] = variable_get('tagadelic_block_title_'. $delta, t('tags in @voc', array('@voc' => $voc->name)));
- $tags = tagadelic_get_weighted_tags(array($voc->vid),6, variable_get('tagadelic_block_tags_'. $delta, 12));
+ $tags = tagadelic_get_weighted_tags(array($voc->vid), variable_get('tagadelic_levels', 6), variable_get('tagadelic_block_tags_'. $delta, 12));
$tags = tagadelic_sort_tags($tags);
$blocks['content'] = theme('tagadelic_weighted', $tags);//return a chunk of 12 tags
}
Comments
#1
please attach a real patch.
#2
For what it's worth, I made the indicated change in 4.7.x, and it seems to work.
#3
hi Bèr Kessels,
the issue still exists with drupal 5.1, and the patch suggested by ardee works fine.
I don't know what you call a "real patch" and anyway this looks like a pain to use the diff tool under windows (well, when I read this thread)
What I've done, is reading the patch files, and applied modifications manually.
This is pretty simple:
Inside function tagadelic_block,
I replace the hardcoded 6, by variable_get('tagadelic_levels', 6)
and then everything work fine.
#4
please look at http://drupal.org/diffandpatch
#5
I've just generated a patch file using WinMerge .
I hope this one is of your taste (file in attachement).
#6
Fixed in 5.x HEAD.
#7
Automatically closed -- issue fixed for two weeks with no activity.