I've applied the conversion routines of Coder Upgrade for fix coding standards.

CommentFileSizeAuthor
#2 webform_import-7.x-1.x-standards-1219228-1.patch18.79 KBvernond
#1 fix_coding_standards-1219228-1.patch7.53 KBrobertom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

robertom’s picture

robertom CreditAttribution: robertom commented
Status: Active » Needs review
FileSize
fix_coding_standards-1219228-1.patch7.53 KB

Attached the patch

vernond’s picture

vernond CreditAttribution: vernond commented
FileSize
webform_import-7.x-1.x-standards-1219228-1.patch18.79 KB

Attached patch against 7.x-1.0 (includes the changes from the patch at the other issue I opened and subsequently closed: Instructions not shown)

Cleaned coder review errors
Fixed instructions displays (theme table and list_item arrays not correct, other markup wasn't being displayed either)
Fixed template download headers
Fixed upload file delete crash
Template and upload process only consider actual input fields (i.e. exclude fieldsets, markup and pagebreaks)
Re-organised and indented code to improve legibility

tomhung’s picture

tomhung CreditAttribution: tomhung commented

We will evaluate this patch ASAP.

Greg

jjemmett’s picture

jjemmett CreditAttribution: jjemmett commented
Status: Needs review » Closed (fixed)

Applied patch to 7.x-1.x branch and created new release 7.x-1.1

Thanks for your work on this.