Closed (fixed)
Project:
Google AdWords Conversion Tracking
Version:
6.x-1.4
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
14 Jul 2011 at 22:32 UTC
Updated:
11 Apr 2014 at 07:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
firebus commentedaha! all other pages work, but does not.
i'm guessing i'm doing something with my template that is incompatible with how google_adwords injects it's code. i'll take a look.
Comment #2
firebus commentednope. this happens on a bare install of d6 and google_adwords. there seems to be no way to get get conversion tracking working on the front page
Comment #3
firebus commentedahh. the problem here is that google_adwords is using hook_node_api, which means it will not work on any page that is not a node, no matter what you have in the paths array. that's a critical bug.
you want to use either hook_init() or module_preprocess_page(). you could also extend your use of hook_footer(). that might be the easiest path. i'll give that a try...
Comment #4
firebus commentedhere's a patch that gets rid of the view case in hook_nodeapi and replaces it with a call to _google_adwords_view_adwords in hook_footer.
to handle cases where we are not viewing a node without having to refactor too much of the existing logic, we create an empty node object to pass to _google_adwords_view_adwords.
Comment #5
firebus commentedComment #6
Preston McMurry commentedConfirmed to now generate conversion javascript to page where it was not previously generated to. (With same data in config screens.) Proven to work in conjunction with the "INSERT INTO google_adwords" patch ( http://drupal.org/node/1135348 ).
Comment #7
NaX commentedManually applied #4 to dev and it work perfectly for me. Used it with a webform.
Comment #8
zionduc commentedThank you Firebus for the patch.
Applied #4 to 6.x-1.4 and it works like charm.
Comment #9
perignon commentedAlthough I'm not a D6 guy. I will see if I can get this applied and committed.
Comment #10
perignon commentedComment #11
perignon commentedCommitted and pushed. Can I get a review on this by someone with D6?
Comment #12
dgitonga commentedTested on D6.28 - confirming AdWords tracking code on non-node page.
Thanks for the module and patch - time saver.
Comment #13
perignon commentedSounds good!
Comment #14
rooby commentedSeems like this has been fixed, but status of the issue says otherwise.
Is this something that should be ported to Drupal 7? or should this issue be marked fixed?
Comment #15
perignon commentedI have not had any request on Drupal 7 for this patch. I honestly haven't looked into what it does because I don't have Drupal 6 or run it.
Comment #16
perignon commented