As it stands now, the module needs the key file to be writable at all times, even if the key file already exists and has a key inside. This patch allows administrators to set permissions on the key file to be read-only, to protect against accidental (or malicious) overwrites. Patch attached.

CommentFileSizeAuthor
#7 encrypt.install.allow-non-writeable-path.patch940 bytesdavidwhthomas
encrypt.install.patch970 bytesNathan Goulding

Comments

Status: Needs review » Needs work

The last submitted patch, encrypt.install.patch, failed testing.

Nathan Goulding’s picture

Nathan Goulding commented

Not sure why this didn't pass. Can someone take a look?

Nathan Goulding’s picture

Nathan Goulding commented
Version: 6.x-1.0-rc5 » 6.x-1.0
Nathan Goulding’s picture

Nathan Goulding commented
Status: Needs work » Needs review

encrypt.install.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, encrypt.install.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

@Nathan Goulding - see the "view details" link "SummaryFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch encrypt.install.patch. See the log in the details link for more information."

From reading the log it looks like it could be an issue with the way the branches are setup.

davidwhthomas’s picture

davidwhthomas commented
StatusFileSize
new encrypt.install.allow-non-writeable-path.patch940 bytes

Here's an adjusted version of the patch for D7

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

For what it's worth: I believe this feature already works properly in the 7.x-2.x branch.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

Drupal 6 is depreciated.