After enabling live_person from the 7.x-1.x branch, and getting admin/config/system/live-person, I don't see the configuration form, and I get this error:

Warning: Parameter 1 to live_person_admin_settings_form() expected to be a reference, value given in drupal_retrieve_form() (line 772 of /var/www/drupal_7/includes/form.inc).

I think the problem is the &$form_state parameter in the signature of live_person_admin_settings_form(&$form_state).

The D7 module tutorial suggests that the signature should be ($form, &$form_state) instead, and ths suggests that the signature should be ($form, &$form_state)

CommentFileSizeAuthor
#1 settings_form_bug-1221142-1.patch430 bytesfirebus

Comments

firebus’s picture

Issue summary: View changes

meant to close that blockquote

firebus’s picture

Status: Active » Needs review
StatusFileSize
new430 bytes

changing the function signature to ($form, &$form_state) seems to fix it

nicholas.alipaz’s picture

Status: Needs review » Fixed

Fixed, committed. Will release when we finish with 2 other issues still in limbo.
http://drupal.org/commitlog/commit/12642/675933ef49bb59ab12febc96611c98d...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

and that node reference was not working