Hi. First of all, i appreciate for this module.
In the mollom. It shows report form when delete node or comment.
Report form has five options. 'Do not report', 'Span...', 'Obsence...', etc.
In version 6.x, this form shows default value that is don't send feedbank to mollom(first option of form).
But, in the 7.x, report form shows default value that is 'Unwanted, taunting, off-topic' (fifth option of form).
I reviewed code of module. default value is 0. 0 is 'Do not report'. But default checked item is different.
i fixed this problem. I attached the patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | mollom.report-form-default.3.patch | 819 bytes | sun |
| mollom.fix-report-default.patch | 825 bytes | barami |
Comments
Comment #1
sunThanks for reporting this issue and also for the patch! :)
This is actually a (major) bug in Drupal core:
#1381140: A #default_value = 0 for #type radios checks all radios
Comment #2
sunComment #3
sunThe new issue for Drupal core is #811542: Regression: Required radios throw illegal choice error when none selected.
As this is actually a bug in core and needs to be fixed there, we won't add a test for this to Mollom module.
However, attached patch changes the option value and default value to a simple empty string.
Will commit later if bot comes back green.
Comment #4
sunThanks for reporting, reviewing, and testing! Committed to 7.x-2.x.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
Comment #5
sunMerged into 6.x-2.x via #1379136: Backport recent changes in 7.x-2.x.