Pass Node

Hi,

I just had a quick look at your module.

(btw you forgot identify yourself to git by "git config user.email "your@email.address")

You should also use two spaces instead of tab.

else statements should begin on a new line
} else {

you can fix things like that quickly by the coder module

Thats it; (I don't know much about 6.x module development)

* .module: @file doc block is missing
* "Implementation of hook_init(). $plugin->execute() sets a context variable to ..." the further description should be in a new paragraph in the doc block. Also elsewhere.
* The indentation of the description "@param $arg" on pass_node_pass_node() is wrong, see http://drupal.org/node/1354#functions
* Remove all old CVS $id tags form your files

This thread has been idle, in the 'needs work' state with no activity for several months. Therefore, I am assuming that you are no longer persuing this application, and marking it as closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open the thred and set the issue status to "needs work" or "needs review", depending on the current status of your code.

Once their first application has been successfully approved, then an applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue.

With this in mind, please reopen only one issue if you choose to re-engage this project application process.

welcome back

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxjupiteriii1216534git.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Please rectify the below errors and strictly follow the drupal coding standards.

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
28 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...-pareview/sites/all/modules/pareview_temp/test_candidate/pass_node.info
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | "description" property is missing in the info file
6 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/pass_node.module
--------------------------------------------------------------------------------
FOUND 8 ERROR(S) AND 5 WARNING(S) AFFECTING 12 LINE(S)
--------------------------------------------------------------------------------
9 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
19 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
36 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
36 | ERROR | Whitespace found at end of line
45 | ERROR | Whitespace found at end of line
46 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
54 | ERROR | Missing parameter type at position 1
56 | ERROR | Whitespace found at end of line
57 | ERROR | Missing parameter type at position 2
67 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
73 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
92 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
120 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...les/pareview_temp/test_candidate/plugins/pass_node_context_reaction.inc
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
9 | ERROR | File doc comments must be followed by a blank line.
10 | ERROR | Class name must begin with a capital letter
10 | ERROR | Class name must use UpperCamel naming without underscores
11 | ERROR | Whitespace found at end of line
15 | ERROR | Method name "pass_node_context_reaction::options_form" is not in
| | lowerCamel format, it must not contain underscores
22 | ERROR | Whitespace found at end of line
29 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...areview_temp/test_candidate/views_plugin_argument_default_pass_node.inc
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
10 | ERROR | File doc comments must be followed by a blank line.
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
18 | ERROR | Method name
| | "views_plugin_argument_default_pass_node::get_argument" is not in
| | lowerCamel format, it must not contain underscores
21 | ERROR | Whitespace found at end of line
26 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

@anilbhatt: Please don't post the output of automated review tools like pareview.sh inline in a comment, as it just clutters the issue. Better add it as .txt attachment instead.

Get a review bonus and we will come back to your application sooner.

Hi,
I saw you have moved code to version specific branch but haven't yet emptied the master branch. Please do so.
Except it quickly running automated review threw some issues, see in attached -> http://ventral.org/pareview/

Thanks.

please don't block indepth reviews because of minor automated detected issues,
anyway I think these are false positives

Yeah my bad, didn't mean to change the status due to just automated review. Apologies.

1. Your GIT-Link is missing, please add it, as not every reviewer want's to check your project page for finding it!

2. Check line indentation and rules for inline documentation:

 * Implements hook_pass_node().
 *   Defines where Pass Node can find the data corresponding to the argument
 *   passed in views. For instance, taxonomy tid and term name can be found
 *   in the $node object, so that is where the hook returns that data.
 *   Alternatively, other implementations of this hook could include a db
 *   query, rather 

I suppose this module is very short for doing a true full project review, I think someone is working actually working on rules concerning that.

You implement hook_pass_node(), but I don't see where it is being called...

-----------------------------------------------------

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
The following git branches do not match the release branch pattern, you should remove/rename them. See http://drupal.org/node/1015226

  remotes/origin/6.x-1.x-dev

Review of the master branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

FILE: ...les/pareview_temp/test_candidate/plugins/pass_node_context_reaction.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 16 | ERROR | Method name "PassNodeContextReaction::options_form" is not in
    |       | lowerCamel format, it must not contain underscores
--------------------------------------------------------------------------------


FILE: ...areview_temp/test_candidate/views_plugin_argument_default_pass_node.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 19 | ERROR | Method name "ViewsPluginArgumentDefaultPassNode::get_argument" is
    |       | not in lowerCamel format, it must not contain underscores
--------------------------------------------------------------------------------

Not sure if normal users also can edit the issue summary, but if I can remember it right you can add the git link your self (?)

this is really not an issue to switch to needs work

ok, i just finished the rest of the review switching back to needs work