The views-admin.rubik.css should only be loaded when on the views ui.

This should not be loaded on every page.

CommentFileSizeAuthor
#8 1221518-rubik-remove_views_css_alter.patch2.11 KBcodi
#3 0002-1221518-by-ericduran-Fixed-The-views-views-admin.rub_.patch4.02 KBfxarte
#1 0001-1221518-by-ericduran-Fixed-The-views-views-admin.rub_.patch7.68 KBericduran

Comments

ericduran’s picture

ericduran commented
Status: Active » Needs review
StatusFileSize
new 0001-1221518-by-ericduran-Fixed-The-views-views-admin.rub_.patch7.68 KB

Here's a patch. This patch does a couple of things.

- It remove views-admin-rubik.css from rubik.info file
- it renames the views-admin-rubik.css to views-admin.rubik.css since thats the appropriate syntax.
- Add a css alter to rubik_css_alter because views will add the css if it's assuming it's on the views module folder. Instead we change the data attribute to replace it with our rubik theme folder.

ericduran’s picture

ericduran commented

FYI: I added a patch to views #1221560: Allow any theme to declare their own views-admin.{theme_key}.css which should make this easier. If that patch gets in, we can remove the css_alter for the views admin css file.

fxarte’s picture

fxarte commented
Assigned: Unassigned » ericduran
StatusFileSize
new 0002-1221518-by-ericduran-Fixed-The-views-views-admin.rub_.patch4.02 KB

I could not apply the patch, there may have been some changes in the theme since it was created so I created a new one

fxarte’s picture

fxarte commented
Assigned: ericduran » Unassigned
ericduran’s picture

ericduran commented
Assigned: ericduran » Unassigned

This patch is no longer needed, at least not the whole patch.

I open an issue in the views queue to fix the problem with views-admin theme not being loaded.

coffeymachine’s picture

coffeymachine commented
Status: Needs review » Fixed

The patch by fxarte did not include the new renamed views-admin.rubik.css. I went ahead and re-did the changes myself and just committed.

Even though views may allow for this in the future, I think this is a fix worth including now. We can revisit this and remove the lines in the rubik_css_alter once #1221560: Allow any theme to declare their own views-admin.{theme_key}.css gets committed and released.

Thanks folks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

codi’s picture

codi commented
Assigned: Unassigned » codi
Status: Closed (fixed) » Needs review
StatusFileSize
new 1221518-rubik-remove_views_css_alter.patch2.11 KB

Sorry to re-open. The change to views was made so I've removed the css_alter.

ericduran’s picture

ericduran commented
Version: 7.x-4.0-beta6 » 7.x-4.x-dev
Status: Needs review » Reviewed & tested by the community

Looks correct to me, and with some clean up :)

coffeymachine’s picture

coffeymachine commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-4.x
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.