option to turn off the prepended message and put it in e-mail headers instead [#1221524]

It would be nice if there was an option to turn off the prepended message. Especially in HTML mail, the message might mess up the eventual output. When showcasing a website to clients they want to see the exact message that was sent out, any additional text can confuse them.

Instead of the prepended message, an additional e-mail header can be added so this info is still available. Also bcc and cc addresses should go into custom e-mail headers so they can be read while developing.

Comment	File	Size	Author
#13	reroute_email.turn_off_prepends_for_d7_1221524_13.patch	12.18 KB	rfay
#12	reroute_email.turn_off_prepends_1221524_12.patch	5.36 KB	rfay
#10	reroute_email.turn_off_prepends_1221524_10.patch	4.2 KB	rfay
#4	reroute-headers-1221524-4.patch	4.2 KB	cyberwolf
#1	reroute-headers-1221524-1.patch	4.2 KB	cyberwolf

Comments

Comment #1

cyberwolf commented 17 July 2011 at 20:12

Status:

Active

» Needs review

Status	File	Size
new	reroute-headers-1221524-1.patch	4.2 KB

Attaching a patch for the D6 branch.

Comment #2

zilverdistel commented 17 August 2011 at 12:56

subscribing

Comment #3

zilverdistel commented 17 August 2011 at 13:46

Status:

Needs review

» Needs work

+++ b/reroute_email.moduleundefined
@@ -34,13 +36,20 @@ function reroute_email_settings() {
+    '#default_value' => variable_get(REROUTE_EMAIL_ENABLE_MESSAGE, 1),
+    '#description' => t('Check this box if you want a message to be prepended to the email body when the mail was rerouted.'),
+  );

I'd use "... when the mail is being rerouted."

+++ b/reroute_email.moduleundefined
@@ -65,36 +74,41 @@ function reroute_email_mail_alter(&$message) {
-    if (in_array($to, $addresslist)) {
-      // To address is in the pass-through list, let it pass through
-      $message['to'] = $to;
-    }
-    else {
+    if (!in_array($to, $addresslist)) {
       // Not on the list, so reroute to the first address in the list

I'm not sure why this has to be changed? Won't this prevent passing through the e-mails to addresses in the pass-through list?

Comment #4

cyberwolf commented 17 August 2011 at 14:11

Status:

Needs work

» Needs review

Status	File	Size
new	reroute-headers-1221524-4.patch	4.2 KB

I changed the description as you suggested.

The current code inside the conditional if (in_array($to, $addresslist)) is actually useless, as $message['to'] already equals $to. As a bit earlier you find this code:

$to = isset($message['to']) ? $message['to'] : t('<to> is missing');

So there is no reason to set it again. That's why I removed that part.

Comment #5

zilverdistel commented 18 August 2011 at 07:29

Status:

Needs review

» Reviewed & tested by the community

Comment #6

adamgerthel commented 19 October 2011 at 11:56

What does this alter exactly? The best thing would be the ability to turn on / off the reroute message via a checkbox @ admin/config/development/reroute_email

Would love that in D7 as well.