Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
aggregator.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Jul 2011 at 02:18 UTC
Updated:
29 Jul 2014 at 19:48 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
aspilicious commentedSomething like this?
Comment #3
aspilicious commentedReconfiguring text editor. Lets see..
Comment #5
aspilicious commentedhmm, another try
Comment #6
jessebeach commentedI removed the code in the template referring to
$source_urland$source_title. Looking at the SQL query that drives the data for the items, the fieldfeed_titleis neither called from the database for the item:nor does it exist as a field in the database for the item
This reduces the complexity of the template down to a simple link and span. I added a call to theme_datetime to render the age of the item as a
<time>element.After making these changes, I started to wonder if the template file is really even necessary. So I made a switch to a theme function for rendering source item summaries. It seems a lot cleaner than a template that gets called often to print two variables.
Comment #7
aspilicious commentedI love it and no visual changes.
RTBC for me
Comment #8
cosmicdreams commentedGreat, simple patch. Will manually test tonight.
Comment #9
dcmouyard commentedThe patch in #6 looks good to me.
Comment #10
cosmicdreams commentedYep, worked well. Tagging for jhodgdon
Comment #11
jhodgdonSorry, I don't think this is really just a coding standards patch -- it's doing a lot more than just converting to use HTML5 (restructuring the theme calls). So I'll leave it for Dries/catch to deal with.
Comment #12
catchLooks great. Committed/pushed to 8.x.
There was one minor issue (double quotes vs. single quotes for the empty space), but I fixed that before commit.
Comment #13
jessebeach commentedGreat, thanks everyone!