There's an unnecessary span (.source) around an anchor. The span can be removed and its class moved to the anchor element.
https://skitch.com/jesse.beach/fkkfk/drupal-dev-netbeans-ide-7.0
The classes should be moved into a template variable.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 1221710_aggregator-summary-item_4.patch | 4.18 KB | jessebeach |
| #5 | aggregator-item-unix-another-try.patch | 2.09 KB | aspilicious |
| #3 | aggregator-item-unix.patch | 2.09 KB | aspilicious |
| #1 | aggregator-item.patch | 2.14 KB | aspilicious |
Comments
Comment #1
aspilicious commentedSomething like this?
Comment #3
aspilicious commentedReconfiguring text editor. Lets see..
Comment #5
aspilicious commentedhmm, another try
Comment #6
jessebeach commentedI removed the code in the template referring to
$source_urland$source_title. Looking at the SQL query that drives the data for the items, the fieldfeed_titleis neither called from the database for the item:nor does it exist as a field in the database for the item
This reduces the complexity of the template down to a simple link and span. I added a call to theme_datetime to render the age of the item as a
<time>element.After making these changes, I started to wonder if the template file is really even necessary. So I made a switch to a theme function for rendering source item summaries. It seems a lot cleaner than a template that gets called often to print two variables.
Comment #7
aspilicious commentedI love it and no visual changes.
RTBC for me
Comment #8
cosmicdreams commentedGreat, simple patch. Will manually test tonight.
Comment #9
dcmouyard commentedThe patch in #6 looks good to me.
Comment #10
cosmicdreams commentedYep, worked well. Tagging for jhodgdon
Comment #11
jhodgdonSorry, I don't think this is really just a coding standards patch -- it's doing a lot more than just converting to use HTML5 (restructuring the theme calls). So I'll leave it for Dries/catch to deal with.
Comment #12
catchLooks great. Committed/pushed to 8.x.
There was one minor issue (double quotes vs. single quotes for the empty space), but I fixed that before commit.
Comment #13
jessebeach commentedGreat, thanks everyone!